11504[TASK] PHP 5.4 adjustments
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Marcus Schwemer +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
Issues 1
Files 3
Review log 7
-
Dmitry Dulepov commented on patch set 1 06/28/12, 19:55
(1 inline comment)init.php:341What about $_ENV, $_COOKIES? (Just wondering) -
Marcus Schwemer commented on patch set 1 06/28/12, 19:55
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 1 06/28/12, 19:55
(1 inline comment)init.php:341ReplyTrue, but please lets change that in a different change request. This is just a dumb backport. -
Oliver Klee commented on patch set 1 06/28/12, 19:55
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 06/28/12, 19:55
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 1 V 0 06/28/12, 19:55
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 1 06/28/12, 19:55