Review TYPO3_4-5 Merged

11504[TASK] PHP 5.4 adjustments

Markus Klein CR +2 V +2 Easy +13 −4 updated 06/03/13, 20:49

Commit message

Small adjustments for PHP 5.4 compatibility.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Marcus Schwemer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1

Issues 1

Files 3

Review log 7

  1. Dmitry Dulepov commented on patch set 1 06/28/12, 19:55

    (1 inline comment)

    init.php:341

    What about $_ENV, $_COOKIES? (Just wondering)
  2. Marcus Schwemer commented on patch set 1 06/28/12, 19:55

    Looks good to me, but someone else must approve
  3. Markus Klein commented on patch set 1 06/28/12, 19:55

    (1 inline comment)

    init.php:341 Reply

    True, but please lets change that in a different change request. This is just a dumb backport.
  4. Oliver Klee commented on patch set 1 06/28/12, 19:55

    Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 1 06/28/12, 19:55

    Verified; Looks good to me, but someone else must approve
  6. Christian Kuhn commented on patch set 1 V 0 06/28/12, 19:55

    by team member; Looks good to me, approved
  7. Christian Kuhn merged patch set 1 06/28/12, 19:55