11549[TASK] Add a comment for require(Bootstrap.php)
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Oliver Klee +1
- Wouter Wolters +1
- Markus Klein +1
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Wouter Wolters +1
- Markus Klein +1
- Philipp Gampe +1
Issues 1
Files 4
Review log 17
-
Markus Klein commented on patch set 1 05/24/12, 05:21
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 2 05/24/12, 05:21
Verified; Looks good to me, but someone else must approve And I've overseen it straight away, because there were already 3 lines ;-) -
Oliver Klee commented on patch set 2 05/24/12, 05:21
Sorry, forgot the "Releases" tag in the commit message of patch set 1. -
Oliver Klee uploaded patch set 2 05/24/12, 05:21
-
Philipp Gampe commented on patch set 2 05/24/12, 05:21
I would prefer that you didn't submit this You missed cli_dispatch.php I will push an update. -
Markus Klein commented on patch set 3 05/24/12, 05:21
Verified; Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 3 05/24/12, 05:21
Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 3 05/24/12, 05:21
-
Philipp Gampe commented on patch set 3 05/24/12, 05:21
Verified; Looks good to me, but someone else must approve I added the comment for typo3/init.php and typo3/cli_dispatch.phpsh too. -
Mr. Jenkins commented on patch set 1 05/24/12, 05:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4187/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/24/12, 05:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4189/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/24/12, 05:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4190/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/24/12, 05:21
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 2 05/24/12, 05:21
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 3 05/24/12, 05:21
Verified; Looks good to me, but someone else must approve -
Tolleiv Nietsch commented on patch set 3 V 0 05/24/12, 05:21
by team member; Looks good to me, approved -
Tolleiv Nietsch merged patch set 3 05/24/12, 05:21