Review main Merged

11549[TASK] Add a comment for require(Bootstrap.php)

Oliver Klee CR +2 V +2 Easy +8 −0 updated 06/03/13, 20:49

Commit message

Bootstrap.php is included using "require" instead of "require_once" to
create a fatal error if Bootstrap.php is included from another place as
well (which would be a bug).

In order to keep people from changing this to "require_once" (as
recommended by the CGL), there should be comment explaining the
situation.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Philipp Gampe +1

Issues 1

Files 4

Review log 17

  1. Markus Klein commented on patch set 1 05/24/12, 05:21

    Verified; Looks good to me, but someone else must approve
  2. Markus Klein commented on patch set 2 05/24/12, 05:21

    Verified; Looks good to me, but someone else must approve And I've overseen it straight away, because there were already 3 lines ;-)
  3. Oliver Klee commented on patch set 2 05/24/12, 05:21

    Sorry, forgot the "Releases" tag in the commit message of patch set 1.
  4. Oliver Klee uploaded patch set 2 05/24/12, 05:21

  5. Philipp Gampe commented on patch set 2 05/24/12, 05:21

    I would prefer that you didn't submit this You missed cli_dispatch.php I will push an update.
  6. Markus Klein commented on patch set 3 05/24/12, 05:21

    Verified; Looks good to me, but someone else must approve
  7. Oliver Klee commented on patch set 3 05/24/12, 05:21

    Looks good to me, but someone else must approve
  8. Philipp Gampe uploaded patch set 3 05/24/12, 05:21

  9. Philipp Gampe commented on patch set 3 05/24/12, 05:21

    Verified; Looks good to me, but someone else must approve I added the comment for typo3/init.php and typo3/cli_dispatch.phpsh too.
  10. Mr. Jenkins commented on patch set 1 05/24/12, 05:21

  11. Mr. Jenkins commented on patch set 2 05/24/12, 05:21

  12. Mr. Jenkins commented on patch set 3 05/24/12, 05:21

  13. Wouter Wolters commented on patch set 1 05/24/12, 05:21

    Verified; Looks good to me, but someone else must approve
  14. Wouter Wolters commented on patch set 2 05/24/12, 05:21

    Verified; Looks good to me, but someone else must approve
  15. Wouter Wolters commented on patch set 3 05/24/12, 05:21

    Verified; Looks good to me, but someone else must approve
  16. Tolleiv Nietsch commented on patch set 3 V 0 05/24/12, 05:21

    by team member; Looks good to me, approved
  17. Tolleiv Nietsch merged patch set 3 05/24/12, 05:21