Review main Merged

11551[TASK] Clean up phpDoc comments in t3lib classes

Wouter Wolters CR +2 V +2 Hard +495 −398 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_userauth.php
* t3lib/class.t3lib_userauthgroup.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Oliver Klee +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 14

  1. Philipp Gampe commented on patch set 1 05/24/12, 05:19

    (4 inline comments)

    class.t3lib_userauth.php:90

    no tab here

    class.t3lib_userauth.php:91

    while you are at it, maybe change the 4.9 to 6.1?

    class.t3lib_userauth.php:94

    please break those comments after 80 chars

    class.t3lib_userauth.php:282

    *R*e-read!
  2. Mr. Jenkins commented on patch set 1 05/24/12, 05:19

  3. Wouter Wolters commented on patch set 1 05/24/12, 05:19

    Last 2 files of t3lib/class.t3lib_* files

    class.t3lib_userauth.php:90 Reply

    Done

    class.t3lib_userauth.php:91 Reply

    Done

    class.t3lib_userauth.php:94 Reply

    Done

    class.t3lib_userauth.php:282 Reply

    Oops typo
  4. Oliver Klee commented on patch set 2 05/24/12, 05:19

    (1 inline comment)
  5. Philipp Gampe commented on patch set 2 05/24/12, 05:19

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 2 05/24/12, 05:19

  7. Wouter Wolters uploaded patch set 2 05/24/12, 05:19

  8. Tolleiv Nietsch commented on patch set 3 V 0 05/24/12, 05:19

    by team member; Looks good to me, approved
  9. Oliver Klee commented on patch set 3 05/24/12, 05:19

    Looks good to me, but someone else must approve
  10. Philipp Gampe commented on patch set 3 05/24/12, 05:19

    Verified; Looks good to me, but someone else must approve Just one tiny change, adding votes again.
  11. Mr. Jenkins commented on patch set 3 05/24/12, 05:19

  12. Wouter Wolters commented on patch set 3 05/24/12, 05:19

    Fixed @Oliver's inline comment.
  13. Wouter Wolters uploaded patch set 3 05/24/12, 05:19

  14. Tolleiv Nietsch merged patch set 3 05/24/12, 05:19