1159[BUGFIX] meaningfulTempFilePrefix generates bad file names in some cases
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Christian Kuhn +1
-
Verified V +2
- Susi Moog +2
- Christian Kuhn +1
Issues 3
Files 1
Review log 12
-
Dmitry Dulepov uploaded patch set 2 04/16/11, 18:46
-
Dmitry Dulepov commented on patch set 2 04/16/11, 18:46
Note: this is ONLY for TYPO3 4.4.7. Other supported branches do not have the issue. -
Christian Kuhn commented on patch set 2 04/16/11, 18:46
Verified; I would prefer that you didn't submit this Confirmed, but why not use the 4.5 and trunk solution from #24956? basicFileFunc->cleanFileName() are identical in 4.4 and 4.5 -
Susi Moog commented on patch set 3 V 0 04/16/11, 18:46
by team member; Looks good to me, approved -
Christian Kuhn uploaded patch set 3 04/16/11, 18:46
-
Christian Kuhn commented on patch set 3 04/16/11, 18:46
Verified; Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 2 V 0 04/16/11, 18:46
by team member; Looks good to me, approved Works as advertised. Code is clean. -
Mr. Jenkins commented on patch set 1 04/16/11, 18:46
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/16/ -
Mr. Jenkins commented on patch set 1 04/16/11, 18:46
Build Started http://ci.typo3.org/job/typo3-v4-core-gerrit/16/ -
Mr. Jenkins commented on patch set 2 04/16/11, 18:46
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/17/ -
Mr. Jenkins commented on patch set 2 04/16/11, 18:46
Build Started http://ci.typo3.org/job/typo3-v4-core-gerrit/17/ -
Susi Moog merged patch set 3 04/16/11, 18:46