11607[BUGFIX] CGL violations FunctionCallArgumentSpacingSpaceBeforeComma
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Oliver Klee +1
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Jigal van Hemert +2
- Philipp Gampe +1
Issues 1
Files 13
- t3lib/l10n/class.t3lib_l10n_store.php+1 −1
- t3lib/class.t3lib_div.php+2 −2
- typo3/sysext/cms/layout/db_layout.php+2 −2
- typo3/sysext/cms/tslib/media/scripts/gmenu_foldout.php+4 −4
- typo3/sysext/cms/tslib/class.tslib_fe.php+3 −3
- typo3/sysext/cms/tslib/class.tslib_pibase.php+1 −1
- typo3/sysext/cms/tslib/class.tslib_search.php+6 −6
- typo3/sysext/impexp/class.tx_impexp.php+2 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+6 −6
- typo3/sysext/indexed_search/pi/class.tx_indexedsearch.php+9 −9
- typo3/sysext/saltedpasswords/tests/tx_saltedpasswords_salts_factoryTest.php+2 −2
- typo3/sysext/scheduler/tests/class.tx_scheduler_croncmd_normalizeTest.php+1 −1
- typo3/sysext/statictemplates/media/scripts/gmenu_foldout.php+4 −4
Review log 7
-
Oliver Klee commented on patch set 1 05/25/12, 18:34
Looks good to me, but someone else must approve -
mostwanted commented on patch set 1 05/25/12, 18:34
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
Jigal van Hemert commented on patch set 1 V 0 05/25/12, 18:34
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 1 05/25/12, 18:34
Verified; Looks good to me, but someone else must approve patch applies clean -
Mr. Jenkins commented on patch set 1 05/25/12, 18:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4207/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/25/12, 18:34
Looks good to me, but someone else must approve -
Jigal van Hemert merged patch set 1 05/25/12, 18:34