Review main Merged

11607[BUGFIX] CGL violations FunctionCallArgumentSpacingSpaceBeforeComma

mostwanted CR +2 V +2 Normal +43 −43 updated 06/03/13, 20:49

Commit message

There are violations against the CGL rule
"FunctionCallArgumentSpacingSpaceBeforeComma". These will be reduced.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Jigal van Hemert +2
    • Philipp Gampe +1

Issues 1

Files 13

Review log 7

  1. Oliver Klee commented on patch set 1 05/25/12, 18:34

    Looks good to me, but someone else must approve
  2. mostwanted commented on patch set 1 05/25/12, 18:34

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  3. Jigal van Hemert commented on patch set 1 V 0 05/25/12, 18:34

    by team member; Looks good to me, approved
  4. Philipp Gampe commented on patch set 1 05/25/12, 18:34

    Verified; Looks good to me, but someone else must approve patch applies clean
  5. Mr. Jenkins commented on patch set 1 05/25/12, 18:34

  6. Wouter Wolters commented on patch set 1 05/25/12, 18:34

    Looks good to me, but someone else must approve
  7. Jigal van Hemert merged patch set 1 05/25/12, 18:34