Review main Merged

11621[BUGFIX] RTE: Empty paragraphs are not correctly transformed

Stanislas Rolland CR +2 V +2 Hard +573 −49 updated 06/03/13, 20:49

Commit message

Problem: Empty paragraphs entered in the RTE may get lost on way to
database if no block is found in content, as well as on way to the RTE
if followed by a block.
Solution: Fix both transformations and add multiple unit test
cases.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Mattias Nilsson +1
  • Verified V +2
    • Christian Kuhn +2
    • Mario Rimann +1
    • Wouter Wolters +1
    • Mattias Nilsson +1

Issues 2

Files 2

Review log 20

  1. Mr. Jenkins commented on patch set 1 03/07/13, 22:37

  2. Wouter Wolters commented on patch set 1 03/07/13, 22:37

    (3 inline comments)

    class.t3lib_parsehtml_proc.php:1117

    Tabs

    class.t3lib_parsehtml_procTest.php:582

    tabs

    class.t3lib_parsehtml_procTest.php:590

    tabs
  3. Stanislas Rolland uploaded patch set 3 03/07/13, 22:37

  4. Stanislas Rolland commented on patch set 3 03/07/13, 22:37

    Rebased.
  5. Mario Rimann commented on patch set 2 03/07/13, 22:37

    (2 inline comments)
  6. Mario Rimann commented on patch set 2 03/07/13, 22:37

    Fails I cannot apply this change on top of the current Git master (rev. badb69d == one commit after the 6.0.0 release)
  7. Mario Rimann commented on patch set 4 V 0 03/07/13, 22:37

    Tested on top of rev. c0defbe74e (master from today) -> applies cleanly and fixes the issue.
  8. Mario Rimann commented on patch set 4 03/07/13, 22:37

    ping
  9. Markus Klein uploaded patch set 4 03/07/13, 22:37

  10. Markus Klein commented on patch set 4 03/07/13, 22:37

    Removed trailing tabs in tests.
  11. Mattias Nilsson commented on patch set 4 03/07/13, 22:37

    Verified; Looks good to me, but someone else must approve
  12. Soeren Kracker commented on patch set 2 03/07/13, 22:37

    Verified; Looks good to me, but someone else must approve tested the patch in TYPO3 4.7: it works
  13. Mr. Jenkins commented on patch set 2 03/07/13, 22:37

  14. Mr. Jenkins commented on patch set 3 03/07/13, 22:37

  15. Mr. Jenkins commented on patch set 4 03/07/13, 22:37

  16. Wouter Wolters uploaded patch set 2 03/07/13, 22:37

  17. Wouter Wolters commented on patch set 2 03/07/13, 22:37

    Verified; Looks good to me, but someone else must approve Fixed the 3 inline comments.
  18. Wouter Wolters commented on patch set 4 03/07/13, 22:37

    Verified; Looks good to me, but someone else must approve Verified with unit-test
  19. Christian Kuhn commented on patch set 4 V 0 03/07/13, 22:37

    by team member; Looks good to me, approved
  20. Christian Kuhn merged patch set 5 03/07/13, 22:37