Review main Merged

11622[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/

mostwanted CR +2 V +2 Hard +386 −386 updated 06/03/13, 20:49

Commit message

There are some violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/. These will be
reduced by this commit.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1

Issues 1

Files 28

Review log 15

  1. mostwanted uploaded patch set 2 05/28/12, 16:43

  2. Oliver Klee commented on patch set 3 05/28/12, 16:43

    Looks good to me, but someone else must approve
  3. Oliver Klee uploaded patch set 4 05/28/12, 16:43

  4. Oliver Klee commented on patch set 4 05/28/12, 16:43

    Verified; Looks good to me, but someone else must approve Rebased to resolve merge conflicts. Tested by running the Core unit tests.
  5. mostwanted uploaded patch set 3 05/28/12, 16:43

  6. mostwanted commented on patch set 3 05/28/12, 16:43

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  7. Georg Ringer commented on patch set 4 V 0 05/28/12, 16:43

    by team member; Looks good to me, approved
  8. Mr. Jenkins commented on patch set 1 05/28/12, 16:43

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4212/ : FAILURE
  9. Mr. Jenkins commented on patch set 2 05/28/12, 16:43

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4213/ : FAILURE
  10. Mr. Jenkins commented on patch set 3 05/28/12, 16:43

  11. Mr. Jenkins commented on patch set 4 05/28/12, 16:43

  12. Wouter Wolters commented on patch set 3 05/28/12, 16:43

    I would prefer that you didn't submit this In general the patch looks good. But you also touched files in typo3/contrib which is third party code. Can you remove those 2 files?
  13. Wouter Wolters commented on patch set 3 05/28/12, 16:43

    Looks good to me, but someone else must approve Ah sorry you pushed already a new version:)
  14. Wouter Wolters commented on patch set 4 05/28/12, 16:43

    Verified; Looks good to me, but someone else must approve Unit tests running fine.
  15. Georg Ringer merged patch set 4 05/28/12, 16:43