11622[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
- Oliver Klee +1
- Wouter Wolters +1
Issues 1
Files 28
- typo3/classes/class.shortcutmenu.php+1 −1
- typo3/alt_clickmenu.php+10 −10
- typo3/alt_db_navframe.php+4 −4
- typo3/alt_doc.php+4 −4
- typo3/alt_doc_nodoc.php+2 −2
- typo3/alt_file_navframe.php+1 −1
- typo3/alt_shortcut.php+60 −60
- typo3/Bootstrap_Cli.php+1 −1
- typo3/class.filelistfoldertree.php+5 −5
- typo3/class.webpagetree.php+24 −24
- typo3/db_new.php+22 −22
- typo3/file_edit.php+2 −2
- typo3/file_newfolder.php+1 −1
- typo3/index.php+5 −5
- typo3/init.php+1 −1
- typo3/move_el.php+26 −26
- typo3/show_item.php+12 −12
- typo3/tce_db.php+3 −3
- typo3/template.php+37 −37
- typo3/view_help.php+34 −34
Review log 15
-
mostwanted uploaded patch set 2 05/28/12, 16:43
-
Oliver Klee commented on patch set 3 05/28/12, 16:43
Looks good to me, but someone else must approve -
Oliver Klee uploaded patch set 4 05/28/12, 16:43
-
Oliver Klee commented on patch set 4 05/28/12, 16:43
Verified; Looks good to me, but someone else must approve Rebased to resolve merge conflicts. Tested by running the Core unit tests. -
mostwanted uploaded patch set 3 05/28/12, 16:43
-
mostwanted commented on patch set 3 05/28/12, 16:43
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
Georg Ringer commented on patch set 4 V 0 05/28/12, 16:43
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 05/28/12, 16:43
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4212/ : FAILURE -
Mr. Jenkins commented on patch set 2 05/28/12, 16:43
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4213/ : FAILURE -
Mr. Jenkins commented on patch set 3 05/28/12, 16:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4214/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/28/12, 16:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4251/ : SUCCESS -
Wouter Wolters commented on patch set 3 05/28/12, 16:43
I would prefer that you didn't submit this In general the patch looks good. But you also touched files in typo3/contrib which is third party code. Can you remove those 2 files? -
Wouter Wolters commented on patch set 3 05/28/12, 16:43
Looks good to me, but someone else must approve Ah sorry you pushed already a new version:) -
Wouter Wolters commented on patch set 4 05/28/12, 16:43
Verified; Looks good to me, but someone else must approve Unit tests running fine. -
Georg Ringer merged patch set 4 05/28/12, 16:43