Review main Abandoned

11635[TASK] Add visibility to t3lib_tcemain member variables

Tolleiv Nietsch CR 0 V 0 Normal +64 −64 updated 06/03/13, 20:49

Commit message

The patch changes as much member variables as possible to "protected"
only the ones which are in use from the outside are left public.

The less we open up the more can be moved / refactored later. From what
I found even internal variables are used at the moment and as long as
there's no technical restriction this might continue.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Oliver Klee commented on patch set 1 06/15/12, 11:06

    Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 06/15/12, 11:06

    Do not submit -2 until this was discussed, see my comment on https://review.typo3.org/#/c/11624/
  3. Mr. Jenkins commented on patch set 1 06/15/12, 11:06

  4. Tolleiv Nietsch commented on patch set 1 06/15/12, 11:06

    Abandoned See newsgroup.