11638[BUGFIX] CGL violations FunctionCallArgumentSpacing in sysext/beuser/
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2
- Jigal van Hemert +2
- Oliver Klee +1
- Wouter Wolters +1
Issues 1
Files 3
Review log 21
-
Gerrit wrote 05/28/12, 13:35
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
mostwanted uploaded patch set 2 05/28/12, 13:35
-
Oliver Klee commented on patch set 3 05/28/12, 13:35
Looks good to me, but someone else must approve -
mostwanted uploaded patch set 3 05/28/12, 13:35
-
mostwanted commented on patch set 3 05/28/12, 13:35
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
Oliver Klee commented on patch set 4 05/28/12, 13:35
Looks good to me, but someone else must approve -
Oliver Klee uploaded patch set 5 05/28/12, 13:35
-
Oliver Klee commented on patch set 5 05/28/12, 13:35
Verified; Looks good to me, but someone else must approve Rebased to fix merge conflicts. Tested with php -l and by using the BE module. -
mostwanted commented on patch set 4 05/28/12, 13:35
deleted line #1115 in /typo3/sysext/beuser/mod/index.php which was deleted in another ones commit in the last 2 days and therefore caused an merging conflict. the rest stays the same. -
mostwanted uploaded patch set 4 05/28/12, 13:35
-
Georg Ringer commented on patch set 3 V 0 05/28/12, 13:35
by team member; Looks good to me, approved -
Jigal van Hemert commented on patch set 5 V 0 05/28/12, 13:35
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 05/28/12, 13:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4228/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/28/12, 13:35
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4229/ : FAILURE -
Mr. Jenkins commented on patch set 3 05/28/12, 13:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4230/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/28/12, 13:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4243/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/28/12, 13:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4247/ : SUCCESS -
Wouter Wolters commented on patch set 3 05/28/12, 13:35
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 4 05/28/12, 13:35
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 5 05/28/12, 13:35
Verified; Looks good to me, but someone else must approve Tested by clicking through the backend module. -
Jigal van Hemert merged patch set 5 05/28/12, 13:35