Review main Merged

11638[BUGFIX] CGL violations FunctionCallArgumentSpacing in sysext/beuser/

mostwanted CR +2 V +2 Normal +95 −95 updated 06/03/13, 20:49

Commit message

There are violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in typo3/sysext/beuser/.
These will be reduced.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Jigal van Hemert +2
    • Oliver Klee +1
    • Wouter Wolters +1

Issues 1

Files 3

Review log 21

  1. Gerrit wrote 05/28/12, 13:35

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. mostwanted uploaded patch set 2 05/28/12, 13:35

  3. Oliver Klee commented on patch set 3 05/28/12, 13:35

    Looks good to me, but someone else must approve
  4. mostwanted uploaded patch set 3 05/28/12, 13:35

  5. mostwanted commented on patch set 3 05/28/12, 13:35

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  6. Oliver Klee commented on patch set 4 05/28/12, 13:35

    Looks good to me, but someone else must approve
  7. Oliver Klee uploaded patch set 5 05/28/12, 13:35

  8. Oliver Klee commented on patch set 5 05/28/12, 13:35

    Verified; Looks good to me, but someone else must approve Rebased to fix merge conflicts. Tested with php -l and by using the BE module.
  9. mostwanted commented on patch set 4 05/28/12, 13:35

    deleted line #1115 in /typo3/sysext/beuser/mod/index.php which was deleted in another ones commit in the last 2 days and therefore caused an merging conflict. the rest stays the same.
  10. mostwanted uploaded patch set 4 05/28/12, 13:35

  11. Georg Ringer commented on patch set 3 V 0 05/28/12, 13:35

    by team member; Looks good to me, approved
  12. Jigal van Hemert commented on patch set 5 V 0 05/28/12, 13:35

    by team member; Looks good to me, approved
  13. Mr. Jenkins commented on patch set 1 05/28/12, 13:35

  14. Mr. Jenkins commented on patch set 2 05/28/12, 13:35

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4229/ : FAILURE
  15. Mr. Jenkins commented on patch set 3 05/28/12, 13:35

  16. Mr. Jenkins commented on patch set 4 05/28/12, 13:35

  17. Mr. Jenkins commented on patch set 5 05/28/12, 13:35

  18. Wouter Wolters commented on patch set 3 05/28/12, 13:35

    Looks good to me, but someone else must approve
  19. Wouter Wolters commented on patch set 4 05/28/12, 13:35

    Looks good to me, but someone else must approve
  20. Wouter Wolters commented on patch set 5 05/28/12, 13:35

    Verified; Looks good to me, but someone else must approve Tested by clicking through the backend module.
  21. Jigal van Hemert merged patch set 5 05/28/12, 13:35