Review main Merged

11639[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/cms/

mostwanted CR +2 V +2 Expert +551 −551 updated 06/03/13, 20:49

Commit message

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/cms/.
These will be reduced by this commit.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1

Issues 1

Files 31

Show 11 more files

Review log 10

  1. Oliver Klee commented on patch set 1 06/01/12, 06:35

    Looks good to me, but someone else must approve
  2. Oliver Klee uploaded patch set 2 06/01/12, 06:35

  3. Oliver Klee commented on patch set 2 06/01/12, 06:35

    Verified; Looks good to me, but someone else must approve Rebased to fix some merge conflicts. Tested by running the cms and Core unit tests and by viewing the start page of my local TYPO3 installation.
  4. mostwanted commented on patch set 1 06/01/12, 06:35

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  5. Mr. Jenkins commented on patch set 1 06/01/12, 06:35

  6. Mr. Jenkins commented on patch set 2 06/01/12, 06:35

  7. Wouter Wolters commented on patch set 1 06/01/12, 06:35

    Looks good to me, but someone else must approve Nice!
  8. Wouter Wolters commented on patch set 2 06/01/12, 06:35

    Verified; Looks good to me, but someone else must approve Unit-tests running fine.
  9. Georg Ringer commented on patch set 2 V 0 06/01/12, 06:35

    by team member; Looks good to me, approved
  10. Georg Ringer merged patch set 2 06/01/12, 06:35