Review main Merged

1165[FEATURE] Streamline element browser in tree, upload & create folder form

Tommy Juhnke CR +2 V +2 Normal +104 −30 updated 06/03/13, 20:49

Commit message

This patch makes the element browser more conform in the three parts by
adding padding to the upload/create folder forms. And move the "display
thumbnails" checkbox to the top of the right tree navigation (right
below the bulk actions).

Furthermore, the three parts are visually splitted by a border which
made it necessary to add new id attributes to the both forms in order
to make them adressable in the stylesheets.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 3

Review log 36

Show 11 earlier messages
  1. Andreas Wolf merged patch set 1 06/08/11, 09:59

  2. Tommy Juhnke commented on patch set 2 06/08/11, 09:59

    Abandoned Jenkins failed with ERROR: Cause: Error performing command: git clone [...] [...] error: index-pack died of signal 15 fatal: index-pack failed Don't know what's wrong but I think it's better to remove this Patch set
  3. Tommy Juhnke uploaded patch set 2 06/08/11, 09:59

  4. Tommy Juhnke commented on patch set 2 06/08/11, 09:59

    Restored Seems like the ci-Team fixed the issue. Jenkins now builds successfully. Thank you :)
  5. Tommy Juhnke commented on patch set 2 06/08/11, 09:59

    Thank you. Maybe it's a good idea to tighten up the lower area by creating tabs for the upload/create folder forms? Any comment on this is highly appreciated.
  6. Philipp Gampe commented on patch set 2 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve Looks much better now
  7. Philipp Gampe commented on patch set 2 06/08/11, 09:59

    Not in this changeset. I think UX/UI Team should decide. Lets discuss this elsewhere.
  8. Tommy Juhnke commented on patch set 3 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve Hi Lorenz, thank you for improving this. I think it's very good this way, even if the file list has a slightly lesser padding (or margin) on top in IE8 and chrome. I don't know if this matters for the rules of browser compatibility. Nonetheless this is a good improvement. Thank you again!
  9. Steffen Gebert commented on patch set 3 06/08/11, 09:59

    I would prefer that you didn't submit this There are some CGL violations (spaces around dots for string concatenation, space after , in function calls..). Will upload a new version.

    class.browse_links.php:2900

    Please don't add new lines
  10. Tommy Juhnke commented on patch set 4 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve Works for me. Teste in: Chromium 11.0.696.57 (82915) Ubuntu 11.04 Firefox 4.0.1 Ubuntu 11.04 Whats up with Jenkins? ;)
  11. Steffen Gebert uploaded patch set 4 06/08/11, 09:59

  1. Steffen Gebert commented on patch set 4 06/08/11, 09:59

    I think it's the problem that Jenkins has a CGL fix as previous build (thus compared to this one, CGL violations are introduced). That's currently a known issue, that the "reference" is not the current state of the official repository, but the last build triggered by the last patch submitted to gerrit.
  2. Andreas Wolf uploaded patch set 6 06/08/11, 09:59

  3. Andreas Wolf commented on patch set 6 V 0 06/08/11, 09:59

    by team member; Looks good to me, approved Pushing after a few CGL adjustments (as mentioned by Georg).
  4. Stefan Neufeind commented on patch set 5 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve
  5. Tommy Juhnke commented on patch set 5 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve
  6. Georg Ringer commented on patch set 5 6 comments 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve
  7. Stefano Kowalke uploaded patch set 5 06/08/11, 09:59

  8. Stefano Kowalke commented on patch set 5 06/08/11, 09:59

    No, this issue is fixed, because I changed the behavoir how jenkins checks for CGL violations. Instead enable all sniffs and calculate the diff of violations, I enable only this sniffs with zero violations in core. The reason for broken build in this case (and some others) is, that the comitter of new patch has not updated his local repo to the last commit (git pull). Jenkins checks the revision out on which the patch based. A rule of thumb: Before push something, be sure that your branch is up-to-date.
  9. Philipp Gampe commented on patch set 3 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve Tested with: Fedora 15: * Opera * Chromium Windows 7 * IE 9 * Safarie * Firefox 4 * Chrome
  10. Philipp Gampe commented on patch set 5 06/08/11, 09:59

    no change in patch
  11. Philipp Gampe commented on patch set 5 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve
  12. Lorenz Ulrich uploaded patch set 3 06/08/11, 09:59

  13. Lorenz Ulrich commented on patch set 3 06/08/11, 09:59

    I improved the patch, please see my comments in the forge issue.
  14. Lorenz Ulrich commented on patch set 5 06/08/11, 09:59

    Verified; Looks good to me, but someone else must approve
  15. Mr. Jenkins commented on patch set 1 06/08/11, 09:59

  16. Mr. Jenkins commented on patch set 1 06/08/11, 09:59

  17. Mr. Jenkins commented on patch set 2 06/08/11, 09:59

  18. Mr. Jenkins commented on patch set 2 06/08/11, 09:59

  19. Mr. Jenkins commented on patch set 2 06/08/11, 09:59

    Fails; I would prefer that you didn't submit this Build Failed SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/35/ FAILURE: http://ci.typo3.org/job/typo3-v4-core-gerrit/35/
  20. Mr. Jenkins commented on patch set 2 06/08/11, 09:59

  21. Mr. Jenkins commented on patch set 2 06/08/11, 09:59

  22. Mr. Jenkins commented on patch set 3 06/08/11, 09:59

  23. Mr. Jenkins commented on patch set 4 06/08/11, 09:59

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/430/ : FAILURE
  24. Mr. Jenkins commented on patch set 5 06/08/11, 09:59

  25. Mr. Jenkins commented on patch set 6 06/08/11, 09:59