11653[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/i*/
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Klee +1
-
Verified V +2
- Georg Ringer +2
- Oliver Klee +1
Issues 1
Files 12
- typo3/sysext/impexp/app/index.php+166 −166
- typo3/sysext/impexp/modfunc1/class.tx_impexp_modfunc1.php+10 −10
- typo3/sysext/impexp/class.tx_impexp.php+183 −183
- typo3/sysext/impexp/class.tx_impexp_clickmenu.php+5 −5
- typo3/sysext/impexp/ext_tables.php+1 −1
- typo3/sysext/indexed_search_mysql/class.tx_indexedsearch_mysql.php+1 −1
- typo3/sysext/info/mod1/index.php+9 −9
- typo3/sysext/info_pagetsconfig/class.tx_infopagetsconfig_webinfo.php+27 −27
- typo3/sysext/info_pagetsconfig/ext_tables.php+1 −1
- typo3/sysext/install/mod/class.tx_install.php+2 −2
- typo3/sysext/install/updates/class.tx_coreupdates_compatversion.php+3 −3
- typo3/sysext/install/ext_tables.php+1 −1
Review log 10
-
Oliver Klee commented on patch set 1 06/01/12, 06:38
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 1 06/01/12, 06:38
Going to push a new version due to merge conflicts. -
Oliver Klee uploaded patch set 2 06/01/12, 06:38
-
Oliver Klee commented on patch set 2 06/01/12, 06:38
Verified; Looks good to me, but someone else must approve Tested with php -l, by running the indexed_search unit tests and by clicking around in the Info module and the install tool. -
mostwanted commented on patch set 1 06/01/12, 06:38
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. The violations in folder /typo3/sysext/indexed_search/ were already reduced in a commit, which is under review at the moment: #37331 -
Mr. Jenkins commented on patch set 1 06/01/12, 06:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4240/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/01/12, 06:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4249/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/01/12, 06:38
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 V 0 06/01/12, 06:38
by team member; Looks good to me, approved -
Georg Ringer merged patch set 2 06/01/12, 06:38