Review main Merged

11653[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/i*/

mostwanted CR +2 V +2 Hard +409 −409 updated 06/03/13, 20:49

Commit message

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/i*/.
These will be reduced by this commit.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2
    • Georg Ringer +2
    • Oliver Klee +1

Issues 1

Files 12

Review log 10

  1. Oliver Klee commented on patch set 1 06/01/12, 06:38

    Looks good to me, but someone else must approve
  2. Oliver Klee commented on patch set 1 06/01/12, 06:38

    Going to push a new version due to merge conflicts.
  3. Oliver Klee uploaded patch set 2 06/01/12, 06:38

  4. Oliver Klee commented on patch set 2 06/01/12, 06:38

    Verified; Looks good to me, but someone else must approve Tested with php -l, by running the indexed_search unit tests and by clicking around in the Info module and the install tool.
  5. mostwanted commented on patch set 1 06/01/12, 06:38

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. The violations in folder /typo3/sysext/indexed_search/ were already reduced in a commit, which is under review at the moment: #37331
  6. Mr. Jenkins commented on patch set 1 06/01/12, 06:38

  7. Mr. Jenkins commented on patch set 2 06/01/12, 06:38

  8. Wouter Wolters commented on patch set 1 06/01/12, 06:38

    Looks good to me, but someone else must approve
  9. Georg Ringer commented on patch set 2 V 0 06/01/12, 06:38

    by team member; Looks good to me, approved
  10. Georg Ringer merged patch set 2 06/01/12, 06:38