11669[TASK] Clean up the phpDoc of t3lib/tree/
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Klee +1
-
Verified V +2
- Georg Ringer +2
Issues 1
Files 23
- t3lib/tree/extdirect/class.t3lib_tree_extdirect_abstractextjstree.php1+0 −1
- t3lib/tree/extdirect/class.t3lib_tree_extdirect_node.php+24 −24
- t3lib/tree/pagetree/extdirect/class.t3lib_tree_pagetree_extdirect_commands.php+9 −9
- t3lib/tree/pagetree/extdirect/class.t3lib_tree_pagetree_extdirect_tree.php+2 −2
- t3lib/tree/pagetree/interfaces/interface.t3lib_tree_pagetree_interfaces_collectionprocessor.php+3 −3
- t3lib/tree/pagetree/interfaces/interface.t3lib_tree_pagetree_interfaces_indicatorprovider.php+1 −1
- t3lib/tree/pagetree/class.t3lib_tree_pagetree_commands.php2+13 −15
- t3lib/tree/pagetree/class.t3lib_tree_pagetree_dataprovider.php+10 −10
- t3lib/tree/pagetree/class.t3lib_tree_pagetree_indicator.php+2 −3
- t3lib/tree/pagetree/class.t3lib_tree_pagetree_node.php+26 −26
- t3lib/tree/renderer/class.t3lib_tree_renderer_abstract.php+3 −3
- t3lib/tree/renderer/class.t3lib_tree_renderer_extjsjson.php+10 −7
- t3lib/tree/renderer/class.t3lib_tree_renderer_unorderedlist.php+8 −8
- t3lib/tree/tca/class.t3lib_tree_tca_abstracttcatreedataprovider.php+8 −9
- t3lib/tree/tca/class.t3lib_tree_tca_databasenode.php+9 −10
- t3lib/tree/tca/class.t3lib_tree_tca_databasetreedataprovider.php2+16 −18
- t3lib/tree/tca/class.t3lib_tree_tca_dataproviderfactory.php3+2 −5
- t3lib/tree/tca/class.t3lib_tree_tca_extjsarrayrenderer.php+2 −2
- t3lib/tree/tca/class.t3lib_tree_tca_tcatree.php+1 −2
- t3lib/tree/class.t3lib_tree_abstractdataprovider.php2+0 −2
Review log 13
-
Oliver Klee commented on patch set 1 05/29/12, 16:19
(7 inline comments) act isclass.t3lib_tree_abstractdataprovider.php:48The @abstract isn't necessary if we have the "real" abstract keyword.class.t3lib_tree_abstractdataprovider.php:57Ditto.class.t3lib_tree_extdirect_abstractextjstree.php:65The @abstract is no necessary as we now have the "real" abstract keyword.class.t3lib_tree_pagetree_commands.php:242As we now have the "real" static keyword, the @static is not necessary anymore IMHO.class.t3lib_tree_pagetree_commands.php:291Ditto.class.t3lib_tree_tca_dataproviderfactory.php:43IMHO we don't need the @static as we have the real static keyword in the function declaration.class.t3lib_tree_tca_dataproviderfactory.php:55AFAIK the @var keyword and the variable name are necessary here. -
Mr. Jenkins commented on patch set 1 05/29/12, 16:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4256/ : SUCCESS -
Oliver Klee commented on patch set 2 05/29/12, 16:19
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 05/29/12, 16:19
(3 inline comments) wanna fix those comments and will merge it afterwards?class.t3lib_tree_tca_databasetreedataprovider.php:240an objectclass.t3lib_tree_tca_databasetreedataprovider.php:315remove the 'A'?class.t3lib_tree_tca_dataproviderfactory.php:123wanna add a @todo ? -
Mr. Jenkins commented on patch set 2 05/29/12, 16:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4259/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/29/12, 16:19
Fixed the inline comments. -
Wouter Wolters uploaded patch set 2 05/29/12, 16:19
-
Oliver Klee commented on patch set 3 05/29/12, 16:19
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 3 V 0 05/29/12, 16:19
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 3 05/29/12, 16:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4261/ : SUCCESS -
Wouter Wolters uploaded patch set 3 05/29/12, 16:19
-
Wouter Wolters commented on patch set 3 05/29/12, 16:19
Fixed the inline comments. -
Georg Ringer merged patch set 3 05/29/12, 16:19