Review main Merged

11669[TASK] Clean up the phpDoc of t3lib/tree/

Wouter Wolters CR +2 V +2 Hard +156 −167 updated 06/03/13, 20:49

Commit message

Clean up the phpDoc of t3lib/tree/

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 23

Show 3 more files

Review log 13

  1. Oliver Klee commented on patch set 1 05/29/12, 16:19

    (7 inline comments) act is

    class.t3lib_tree_abstractdataprovider.php:48

    The @abstract isn't necessary if we have the "real" abstract keyword.

    class.t3lib_tree_abstractdataprovider.php:57

    Ditto.

    class.t3lib_tree_extdirect_abstractextjstree.php:65

    The @abstract is no necessary as we now have the "real" abstract keyword.

    class.t3lib_tree_pagetree_commands.php:242

    As we now have the "real" static keyword, the @static is not necessary anymore IMHO.

    class.t3lib_tree_pagetree_commands.php:291

    Ditto.

    class.t3lib_tree_tca_dataproviderfactory.php:43

    IMHO we don't need the @static as we have the real static keyword in the function declaration.

    class.t3lib_tree_tca_dataproviderfactory.php:55

    AFAIK the @var keyword and the variable name are necessary here.
  2. Mr. Jenkins commented on patch set 1 05/29/12, 16:19

  3. Oliver Klee commented on patch set 2 05/29/12, 16:19

    Looks good to me, but someone else must approve
  4. Georg Ringer commented on patch set 2 05/29/12, 16:19

    (3 inline comments) wanna fix those comments and will merge it afterwards?

    class.t3lib_tree_tca_databasetreedataprovider.php:240

    an object

    class.t3lib_tree_tca_databasetreedataprovider.php:315

    remove the 'A'?

    class.t3lib_tree_tca_dataproviderfactory.php:123

    wanna add a @todo ?
  5. Mr. Jenkins commented on patch set 2 05/29/12, 16:19

  6. Wouter Wolters commented on patch set 2 05/29/12, 16:19

    Fixed the inline comments.
  7. Wouter Wolters uploaded patch set 2 05/29/12, 16:19

  8. Oliver Klee commented on patch set 3 05/29/12, 16:19

    Looks good to me, but someone else must approve
  9. Georg Ringer commented on patch set 3 V 0 05/29/12, 16:19

    by team member; Looks good to me, approved
  10. Mr. Jenkins commented on patch set 3 05/29/12, 16:19

  11. Wouter Wolters uploaded patch set 3 05/29/12, 16:19

  12. Wouter Wolters commented on patch set 3 05/29/12, 16:19

    Fixed the inline comments.
  13. Georg Ringer merged patch set 3 05/29/12, 16:19