Review main Merged

1169[BUGFIX] Extension Manager Function "Backup/Delete => Dump Tables" doesn't work any more

Steffen Kamper CR +2 V +1 Easy +1 −1 updated 06/03/13, 20:49

Commit message

If you try to dump Tables via Extension Manager, you will get a file which looks like this:
...
INSERT INTO static_languages VALUES (NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
INSERT INTO static_languages VALUES (NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
...

Reason:
tx_em_database::dumpTableContent uses associative Array $fieldStructure to access the database fields. Although $fieldStructure contains a mapping $field => $structure, the fields are read in a foreach-loop which uses the values of the array.

Review

  • Code review CR +2
    • Steffen Kamper +2
    • Björn Pedersen +1
  • Verified V +1
    • Steffen Kamper +1

Files 1

Review log 7

  1. Björn Pedersen commented on patch set 1 03/16/11, 08:28

    Looks good to me, but someone else must approve
  2. Björn Pedersen commented on patch set 2 03/16/11, 08:28

    Looks good to me, but someone else must approve
  3. Steffen Kamper commented on patch set 2 03/16/11, 08:28

    Verified; Looks good to me, approved
  4. Steffen Kamper uploaded patch set 2 03/16/11, 08:28

  5. Mr. Jenkins commented on patch set 1 03/16/11, 08:28

  6. Mr. Jenkins commented on patch set 1 03/16/11, 08:28

  7. Steffen Kamper merged patch set 2 03/16/11, 08:28