Review main Merged

11700[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/l*/

mostwanted CR +2 V +2 Hard +165 −165 updated 06/03/13, 20:49

Commit message

There were violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/l*/.
These will be reduced by this commit.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 17

Review log 9

  1. Stefan Neufeind commented on patch set 1 06/01/12, 13:47

    Should add other whitespace-changes as well - at least for the lines which are touched anyway. It aren't that many, please just go through them. Or could you add another regex on your IDE for that as well? Also see #11703.
  2. Stefan Neufeind commented on patch set 1 06/01/12, 13:47

    Looks good to me, but someone else must approve Hmm well, your "task" is just about this one special kind of CGL-violations I understood now. Okay then. But then please* also submit a task for those whitespace-fixes as well. Shouldn't be hard to do but will improve readability a lot!
  3. Oliver Klee commented on patch set 1 06/01/12, 13:47

    Looks good to me, but someone else must approve
  4. mostwanted commented on patch set 1 06/01/12, 13:47

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  5. Georg Ringer commented on patch set 1 06/01/12, 13:47

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 06/01/12, 13:47

  7. Wouter Wolters commented on patch set 1 06/01/12, 13:47

    Looks good to me, but someone else must approve
  8. Georg Ringer commented on patch set 1 V 0 06/01/12, 13:47

    by team member; Looks good to me, approved
  9. Georg Ringer merged patch set 1 06/01/12, 13:47