11703[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/p*/
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Stefan Neufeind +1
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
Issues 1
Files 1
Review log 10
-
Stefan Neufeind commented on patch set 1 06/01/12, 13:45
(2 inline comments) Should add other whitespace-changes as well - at least for the lines which are touched anyway. It aren't that many, please just go through them. Or could you add another regex on your IDE for that as well?index.php:243if you're at it kindly also add whitespaces around assignments (here: =>) in one go as wellindex.php:253whitespaces around dots for concatenating strings as well, please -
Stefan Neufeind commented on patch set 1 06/01/12, 13:45
Looks good to me, but someone else must approve Hmm well, your "task" is just about this one special kind of CGL-violations I understood now. Okay then. But then please* also submit a task for those whitespace-fixes as well. Shouldn't be hard to do but will improve readability a lot! -
Oliver Klee commented on patch set 1 06/01/12, 13:45
Looks good to me, but someone else must approve -
mostwanted commented on patch set 1 06/01/12, 13:45
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
mostwanted commented on patch set 1 06/01/12, 13:45
thanks for reviewing. i was told to focus on one CGL violation, because it should make reviewing easier and less error prone. it also makes it easier for me to semi-automate my tasks - and make it less error prone too. i will continue reducing all the CGL violations which are shown on metric.typo3.org - i hope concatenations and assignment whitspace CGL violations are listet there... ...oh, i just see, that they are not listed there. maybe somebody could add this to the existing metrics.typo3.org tests? what do you think? -
Georg Ringer commented on patch set 1 06/01/12, 13:45
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 1 V 0 06/01/12, 13:45
by team member; Looks good to me, approved one CGL after another is fine, especially with reviewing, no matter if one file or even one line is touched more than once -
Mr. Jenkins commented on patch set 1 06/01/12, 13:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4269/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/01/12, 13:45
Looks good to me, but someone else must approve -
Georg Ringer merged patch set 1 06/01/12, 13:45