Review main Merged

1175[FEATURE] Add support for FlexForm file reference

Rens Admiraal CR +2 V +2 Easy +7 −1 updated 06/03/13, 20:49

Commit message

Now t3lib_befunc->getFlexFormDS supports pointers to a file, or to
a table containing the XML for the datastructure. I'm currently in
the need of storing a file location in this reference table, which
is not possible in current method.

My suggestion would be to validate the datastructure field in the
database to see if it's a file or XML, and handle it depending on
the outcome. Suggestion for a solution can be found in this changeset.

See the mantis bug report for a test extension to reproduce this.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Julian Hofmann +1
    • Rens Admiraal +1
    • Georg Ringer +1
    • Tolleiv Nietsch +1
    • Christian Müller +1
  • Verified V +2
    • Andreas Wolf +2
    • Rens Admiraal +1
    • Georg Ringer +1

Files 1

Review log 9

  1. Andreas Wolf commented on patch set 1 V 0 06/12/11, 16:28

    by team member; Looks good to me, approved Pushing after my code review and two positive verifications.
  2. Tolleiv Nietsch commented on patch set 1 06/12/11, 16:28

    Looks good to me, but someone else must approve
  3. Christian Müller commented on patch set 1 06/12/11, 16:28

    Looks good to me, but someone else must approve
  4. Julian Hofmann commented on patch set 1 06/12/11, 16:28

    Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 1 06/12/11, 16:28

    Verified; Looks good to me, but someone else must approve
  6. Rens Admiraal commented on patch set 1 06/12/11, 16:28

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 06/12/11, 16:28

  8. Mr. Jenkins commented on patch set 1 06/12/11, 16:28

  9. Andreas Wolf merged patch set 1 06/12/11, 16:28