Review main Merged

11769[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/s*/

mostwanted CR +2 V +2 Easy +15 −19 updated 06/03/13, 20:49

Commit message

There are violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/s*/.
These will be reduced by this commit.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 6

Review log 9

  1. mostwanted commented on patch set 1 06/01/12, 13:54

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  2. mostwanted uploaded patch set 2 06/01/12, 13:54

  3. mostwanted commented on patch set 2 06/01/12, 13:54

    thanks for the hint. i only touched class.tx_sv_auth.php.
  4. Mr. Jenkins commented on patch set 1 06/01/12, 13:54

  5. Mr. Jenkins commented on patch set 2 06/01/12, 13:54

  6. Wouter Wolters commented on patch set 1 06/01/12, 13:54

    (2 inline comments) See my comments

    class.tx_sv_auth.php:180

    space are missing

    class.tx_sv_auth.php:196

    spaces are missing
  7. Wouter Wolters commented on patch set 2 06/01/12, 13:54

    Looks good to me, but someone else must approve
  8. Georg Ringer commented on patch set 2 V 0 06/01/12, 13:54

    by team member; Looks good to me, approved
  9. Georg Ringer merged patch set 2 06/01/12, 13:54