11772[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/w*/
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
Issues 1
Files 3
Review log 9
-
mostwanted commented on patch set 1 06/01/12, 13:49
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
mostwanted uploaded patch set 2 06/01/12, 13:49
-
mostwanted commented on patch set 2 06/01/12, 13:49
added 2 missing spaces. thanks for the hint. -
Georg Ringer commented on patch set 2 V 0 06/01/12, 13:49
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 06/01/12, 13:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4287/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/01/12, 13:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4289/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/01/12, 13:49
(2 inline comments) Some spaces are missingclass.tx_wizardsortpages_webfunc_2.php:78space missingclass.tx_wizardsortpages_webfunc_2.php:80space missing -
Wouter Wolters commented on patch set 2 06/01/12, 13:49
Looks good to me, but someone else must approve -
Georg Ringer merged patch set 2 06/01/12, 13:49