Review main Merged

11772[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/w*/

mostwanted CR +2 V +2 Easy +18 −18 updated 06/03/13, 20:49

Commit message

There are violations against the CGL rule
"FunctionCallArgumentSpacingNoSpaceAfterComma" in /typo3/sysext/w*/.
These will be reduced by this commit.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 3

Review log 9

  1. mostwanted commented on patch set 1 06/01/12, 13:49

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  2. mostwanted uploaded patch set 2 06/01/12, 13:49

  3. mostwanted commented on patch set 2 06/01/12, 13:49

    added 2 missing spaces. thanks for the hint.
  4. Georg Ringer commented on patch set 2 V 0 06/01/12, 13:49

    by team member; Looks good to me, approved
  5. Mr. Jenkins commented on patch set 1 06/01/12, 13:49

  6. Mr. Jenkins commented on patch set 2 06/01/12, 13:49

  7. Wouter Wolters commented on patch set 1 06/01/12, 13:49

    (2 inline comments) Some spaces are missing

    class.tx_wizardsortpages_webfunc_2.php:78

    space missing

    class.tx_wizardsortpages_webfunc_2.php:80

    space missing
  8. Wouter Wolters commented on patch set 2 06/01/12, 13:49

    Looks good to me, but someone else must approve
  9. Georg Ringer merged patch set 2 06/01/12, 13:49