11796[TASK] Fix CGL violations against InlineCommentWrongStyle
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
-
Verified V +2
- Georg Ringer +2
Issues 1
Files 8
- t3lib/class.t3lib_befunc.php2+1 −1
- typo3/sysext/cms/tslib/class.tslib_fe.php1+3 −2
- typo3/sysext/indexed_search/class.crawler.php+2 −3
- typo3/sysext/indexed_search/ext_localconf.php+4 −2
- typo3/sysext/install/Classes/Updates/File/TceformsUpdateWizard.php1+9 −6
- typo3/sysext/rtehtmlarea/mod5/class.tx_rtehtmlarea_user.php+1 −1
- typo3/sysext/sv/class.tx_sv_auth.php+2 −2
- typo3/sysext/tstemplate_ceditor/class.tx_tstemplateceditor.php+1 −1
Review log 8
-
mostwanted commented on patch set 1 06/01/12, 18:00
(1 inline comment) This fix was done manually according the violatios shown on metrics.typo3.org. My IDE did not indicate any php errors.class.t3lib_befunc.php:965does ###NOTE_A### mean something special, or can we delete it? -
Georg Ringer commented on patch set 1 06/01/12, 18:00
(3 inline comments)class.t3lib_befunc.php:965Replyyeah we can remove itclass.tslib_fe.php:2233UppercaseTceformsUpdateWizard.php:96Relative instead of relative -
Mr. Jenkins commented on patch set 1 06/01/12, 18:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4302/ : SUCCESS -
Georg Ringer commented on patch set 2 V 0 06/01/12, 18:00
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 2 06/01/12, 18:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4307/ : SUCCESS -
Wouter Wolters uploaded patch set 2 06/01/12, 18:00
-
Wouter Wolters commented on patch set 2 06/01/12, 18:00
@Georg fixed the mentioned points:) -
Georg Ringer merged patch set 2 06/01/12, 18:00