Review main Merged

11796[TASK] Fix CGL violations against InlineCommentWrongStyle

mostwanted CR +2 V +2 Easy +23 −18 updated 06/03/13, 20:49

Commit message

There are violations against the CGL rule "InlineCommentWrongStyle".

These will be fixed.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 8

Review log 8

  1. mostwanted commented on patch set 1 06/01/12, 18:00

    (1 inline comment) This fix was done manually according the violatios shown on metrics.typo3.org. My IDE did not indicate any php errors.

    class.t3lib_befunc.php:965

    does ###NOTE_A### mean something special, or can we delete it?
  2. Georg Ringer commented on patch set 1 06/01/12, 18:00

    (3 inline comments)

    class.t3lib_befunc.php:965 Reply

    yeah we can remove it

    class.tslib_fe.php:2233

    Uppercase

    TceformsUpdateWizard.php:96

    Relative instead of relative
  3. Mr. Jenkins commented on patch set 1 06/01/12, 18:00

  4. Georg Ringer commented on patch set 2 V 0 06/01/12, 18:00

    by team member; Looks good to me, approved
  5. Mr. Jenkins commented on patch set 2 06/01/12, 18:00

  6. Wouter Wolters uploaded patch set 2 06/01/12, 18:00

  7. Wouter Wolters commented on patch set 2 06/01/12, 18:00

    @Georg fixed the mentioned points:)
  8. Georg Ringer merged patch set 2 06/01/12, 18:00