Review main Merged

11797[TASK] Reduce CGL violations DoubleQuoteUsageNotRequired in /typo3/

mostwanted CR +2 V +2 Normal +34 −34 updated 06/03/13, 20:49

Commit message

There are violations against the CGL rule "DoubleQuoteUsageNotRequired" in
/typo3/ (not: /typo3/sysest/).

These will be reduced.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2
    • Oliver Klee +1

Issues 1

Files 11

Review log 5

  1. Oliver Klee commented on patch set 1 06/10/12, 16:10

    Verified; Looks good to me, but someone else must approve Tested by running the Core unit tests.
  2. mostwanted commented on patch set 1 06/10/12, 16:10

    This fix was done manually according the violatios shown on metrics.typo3.org. My IDE did not indicate any php errors.
  3. Mr. Jenkins commented on patch set 1 06/10/12, 16:10

  4. Christian Kuhn commented on patch set 1 V 0 06/10/12, 16:10

    by team member; Looks good to me, approved
  5. Christian Kuhn merged patch set 1 06/10/12, 16:10