Review main Merged

11841[TASK] CGL FunctionCallArgumentSpacingNoSpace in fe_adminLib.inc

mostwanted CR +2 V +2 Normal +85 −83 updated 06/03/13, 20:49

Commit message

There are CGL violations against
FunctionCallArgumentSpacingNoSpaceAfterComma in
typo3/sysext/cms/tslib/media/scripts/fe_adminLib.inc.

These will be reduced.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 5

  1. Oliver Klee commented on patch set 1 06/10/12, 15:22

    Looks good to me, but someone else must approve
  2. mostwanted commented on patch set 1 06/10/12, 15:22

    This fix was semi-automated in my IDE via regex search and manual replace. Most probably there are some violations left. These will be fixed in the near future as "the last 20%". ;-) My IDE did not indicate any php errors.
  3. Mr. Jenkins commented on patch set 1 06/10/12, 15:22

  4. Christian Kuhn commented on patch set 1 V 0 06/10/12, 15:22

    by team member; Looks good to me, approved
  5. Christian Kuhn merged patch set 1 06/10/12, 15:22