Review main Merged

11843[TASK] Harmonize coding style of if constructs in /typo3/classes/

mostwanted CR +2 V +2 Normal +76 −76 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 5

Review log 8

  1. Oliver Klee commented on patch set 2 06/06/12, 05:29

    Looks good to me, but someone else must approve
  2. mostwanted commented on patch set 2 06/06/12, 05:29

  3. mostwanted commented on patch set 2 06/06/12, 05:29

    Would be great if all if constructs would be styled the same way. This is not part of the CGL. I would like to hear your opinion if you would also like to have harmonized coding style of all if constructs. If so i could push some more of those commits. This fix was automated in my IDE via regex search and replace. I reviewed it before pushing it to gerrit. My IDE did not indicate any php errors.
  4. mostwanted uploaded patch set 2 06/06/12, 05:29

  5. Georg Ringer commented on patch set 2 V 0 06/06/12, 05:29

    by team member; Looks good to me, approved
  6. Mr. Jenkins commented on patch set 1 06/06/12, 05:29

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4331/ : FAILURE
  7. Mr. Jenkins commented on patch set 2 06/06/12, 05:29

  8. Georg Ringer merged patch set 2 06/06/12, 05:29