11849[TASK] Harmonize coding style of if constructs in /typo3/sysext/cms/
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 24
- typo3/sysext/cms/layout/db_layout.php+4 −4
- typo3/sysext/cms/layout/db_new_content_el.php+2 −2
- typo3/sysext/cms/tslib/content/class.tslib_content_case.php+1 −1
- typo3/sysext/cms/tslib/content/class.tslib_content_columns.php+1 −1
- typo3/sysext/cms/tslib/content/class.tslib_content_fluidtemplate.php+8 −8
- typo3/sysext/cms/tslib/content/class.tslib_content_form.php+3 −3
- typo3/sysext/cms/tslib/content/class.tslib_content_horizontalruler.php+2 −2
- typo3/sysext/cms/tslib/content/class.tslib_content_imagetext.php+3 −3
- typo3/sysext/cms/tslib/content/class.tslib_content_loadregister.php+3 −3
- typo3/sysext/cms/tslib/content/class.tslib_content_multimedia.php+2 −2
- typo3/sysext/cms/tslib/content/class.tslib_content_quicktimeobject.php+2 −2
- typo3/sysext/cms/tslib/content/class.tslib_content_scalablevectorgraphics.php+3 −3
- typo3/sysext/cms/tslib/content/class.tslib_content_shockwaveflashobject.php+3 −3
- typo3/sysext/cms/tslib/content/class.tslib_content_template.php+1 −1
- typo3/sysext/cms/tslib/content/class.tslib_content_text.php+1 −1
- typo3/sysext/cms/tslib/hooks/class.tx_cms_treelistcacheupdate.php+2 −2
- typo3/sysext/cms/tslib/class.tslib_adminpanel.php+1 −1
- typo3/sysext/cms/tslib/class.tslib_content.php+14 −14
- typo3/sysext/cms/tslib/class.tslib_fe.php+8 −8
- typo3/sysext/cms/tslib/class.tslib_feuserauth.php+4 −4
Review log 10
-
Gerrit wrote 06/11/12, 18:15
Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. -
Oliver Klee commented on patch set 1 06/11/12, 18:15
Looks good to me, but someone else must approve -
mostwanted commented on patch set 1 06/11/12, 18:15
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
Christian Kuhn commented on patch set 1 V 0 06/11/12, 18:15
by team member; Looks good to me, approved -
Christian Kuhn uploaded patch set 2 06/11/12, 18:15
-
Mr. Jenkins commented on patch set 1 06/11/12, 18:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4337/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/11/12, 18:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4362/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/11/12, 18:15
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 2 V 0 06/11/12, 18:15
by team member; Looks good to me, approved Rebased, merged. -
Christian Kuhn merged patch set 2 06/11/12, 18:15