11897[TASK] Clean up phpDoc comments in typo3/classes
Commit message
Review
-
Code review CR +2
- Susi Moog +2
-
Verified V +2
- Susi Moog +2
Issues 1
Files 8
- typo3/classes/class.ajaxlogin.php+18 −19
- typo3/classes/class.clearcachemenu.php+19 −13
- typo3/classes/class.livesearch.php+10 −10
- typo3/classes/class.modulemenu.php6+32 −38
- typo3/classes/class.shortcutmenu.php2+98 −97
- typo3/classes/class.typo3ajax.php4+42 −54
- typo3/classes/class.typo3logo.php+9 −10
- typo3/classes/class.typo3_tcefile.php4+9 −12
Review log 11
-
Oliver Klee commented on patch set 1 06/11/12, 17:25
(8 inline comments)class.modulemenu.php:55No @return for constructors, please.class.modulemenu.php:102object -> TYPO3AJAXclass.modulemenu.php:303The parameter name is missing.class.shortcutmenu.php:74Constructors have no return value and thus must have no @return.class.typo3_tcefile.php:158string -> arrayclass.typo3_tcefile.php:159string -> TYPO3AJAXclass.typo3ajax.php:109The parameter names are missing.class.typo3ajax.php:163The parameter name is missing. -
Oliver Klee commented on patch set 1 06/11/12, 17:25
I would prefer that you didn't submit this -
Mr. Jenkins commented on patch set 1 06/11/12, 17:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4344/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/11/12, 17:25
Will resubmit in 3 hours:)class.modulemenu.php:55ReplyDoneclass.modulemenu.php:102ReplyDoneclass.modulemenu.php:303ReplyDoneclass.shortcutmenu.php:74ReplyDoneclass.typo3_tcefile.php:158ReplyDoneclass.typo3_tcefile.php:159ReplyDoneclass.typo3ajax.php:109ReplyDoneclass.typo3ajax.php:163ReplyDone -
Wouter Wolters commented on patch set 1 06/11/12, 17:25
(8 inline comments) -
Susi Moog uploaded patch set 3 06/11/12, 17:25
-
Mr. Jenkins commented on patch set 2 06/11/12, 17:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4357/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/11/12, 17:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4359/ : SUCCESS -
Wouter Wolters uploaded patch set 2 06/11/12, 17:25
-
Susi Moog commented on patch set 3 V 0 06/11/12, 17:25
by team member; Looks good to me, approved Merged as no-brainer. -
Susi Moog merged patch set 3 06/11/12, 17:25