11898[TASK] CGL FunctionCallArgumentSpacingNoSpaceAfterComma in indexed_search
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 7
- typo3/sysext/indexed_search/modfunc1/class.tx_indexedsearch_modfunc1.php+2 −2
- typo3/sysext/indexed_search/modfunc2/class.tx_indexedsearch_modfunc2.php+3 −3
- typo3/sysext/indexed_search/class.crawler.php+47 −46
- typo3/sysext/indexed_search/class.external_parser.php+18 −17
- typo3/sysext/indexed_search/class.indexer.php2+100 −88
- typo3/sysext/indexed_search/class.lexer.php4+13 −11
- typo3/sysext/indexed_search/ext_tables.php+2 −2
Review log 11
-
Oliver Klee commented on patch set 1 06/11/12, 17:52
(2 inline comments)class.indexer.php:508While this is touched anyway: timestatmp -> timestampclass.lexer.php:124This empty string wasn't here in the original code. -
Oliver Klee commented on patch set 1 06/11/12, 17:52
(1 inline comment) -
Oliver Klee commented on patch set 1 06/11/12, 17:52
I would prefer that you didn't submit this -
mostwanted commented on patch set 1 06/11/12, 17:52
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.class.indexer.php:508Replythanks. i will change this in the evening.class.lexer.php:124Replyi think it is the most readable string concatenation style if you start with an empty string in the first line. what do you think? if you do not agree i can change this in the evening.class.lexer.php:124Replyok, i will remove it. -
mostwanted commented on patch set 1 06/11/12, 17:52
(1 inline comment) -
mostwanted commented on patch set 1 06/11/12, 17:52
(2 inline comments) -
Christian Kuhn uploaded patch set 2 06/11/12, 17:52
-
Christian Kuhn commented on patch set 2 V 0 06/11/12, 17:52
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 06/11/12, 17:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4345/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/11/12, 17:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4361/ : SUCCESS -
Christian Kuhn merged patch set 2 06/11/12, 17:52