Review main Merged

11898[TASK] CGL FunctionCallArgumentSpacingNoSpaceAfterComma in indexed_search

mostwanted CR +2 V +2 Hard +185 −169 updated 06/03/13, 20:49

Commit message

A few other CGL violations will also be reduced.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 7

Review log 11

  1. Oliver Klee commented on patch set 1 06/11/12, 17:52

    (2 inline comments)

    class.indexer.php:508

    While this is touched anyway: timestatmp -> timestamp

    class.lexer.php:124

    This empty string wasn't here in the original code.
  2. Oliver Klee commented on patch set 1 06/11/12, 17:52

    (1 inline comment)
  3. Oliver Klee commented on patch set 1 06/11/12, 17:52

    I would prefer that you didn't submit this
  4. mostwanted commented on patch set 1 06/11/12, 17:52

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.

    class.indexer.php:508 Reply

    thanks. i will change this in the evening.

    class.lexer.php:124 Reply

    i think it is the most readable string concatenation style if you start with an empty string in the first line. what do you think? if you do not agree i can change this in the evening.

    class.lexer.php:124 Reply

    ok, i will remove it.
  5. mostwanted commented on patch set 1 06/11/12, 17:52

    (1 inline comment)
  6. mostwanted commented on patch set 1 06/11/12, 17:52

    (2 inline comments)
  7. Christian Kuhn uploaded patch set 2 06/11/12, 17:52

  8. Christian Kuhn commented on patch set 2 V 0 06/11/12, 17:52

    by team member; Looks good to me, approved
  9. Mr. Jenkins commented on patch set 1 06/11/12, 17:52

  10. Mr. Jenkins commented on patch set 2 06/11/12, 17:52

  11. Christian Kuhn merged patch set 2 06/11/12, 17:52