Review main Merged

11914[TASK] CGL FunctionCallArgumentSpacingNoSpaceAfterComma in statictemplates

mostwanted CR +2 V +2 Hard +192 −178 updated 06/03/13, 20:49

Commit message

A few other CGL violations will also be reduced.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 15

Review log 5

  1. Oliver Klee commented on patch set 1 06/11/12, 16:16

    Looks good to me, but someone else must approve
  2. mostwanted commented on patch set 1 06/11/12, 16:16

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  3. Christian Kuhn commented on patch set 1 V 0 06/11/12, 16:16

    by team member; Looks good to me, approved
  4. Mr. Jenkins commented on patch set 1 06/11/12, 16:16

  5. Christian Kuhn merged patch set 1 06/11/12, 16:16