11914[TASK] CGL FunctionCallArgumentSpacingNoSpaceAfterComma in statictemplates
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 15
- typo3/sysext/statictemplates/media/scripts/example_callfunction.php+3 −3
- typo3/sysext/statictemplates/media/scripts/example_itemArrayProcFunc.php+1 −1
- typo3/sysext/statictemplates/media/scripts/example_keepRollover.php+1 −1
- typo3/sysext/statictemplates/media/scripts/example_languageMenu.php+1 −1
- typo3/sysext/statictemplates/media/scripts/example_typolinkpop.php+2 −2
- typo3/sysext/statictemplates/media/scripts/fe_adminLib.inc+28 −25
- typo3/sysext/statictemplates/media/scripts/gmenu_foldout.php+6 −6
- typo3/sysext/statictemplates/media/scripts/gmenu_layers.php+52 −50
- typo3/sysext/statictemplates/media/scripts/makeMenu_datedirectory.inc+12 −9
- typo3/sysext/statictemplates/media/scripts/plaintextLib.inc+12 −12
- typo3/sysext/statictemplates/media/scripts/postit.inc+6 −6
- typo3/sysext/statictemplates/media/scripts/testscript_EXT.php+1 −1
- typo3/sysext/statictemplates/media/scripts/tmenu_layers.php+28 −27
- typo3/sysext/statictemplates/media/scripts/wapversionLib.inc+32 −27
- typo3/sysext/statictemplates/media/scripts/xmlversionLib.inc+7 −7
Review log 5
-
Oliver Klee commented on patch set 1 06/11/12, 16:16
Looks good to me, but someone else must approve -
mostwanted commented on patch set 1 06/11/12, 16:16
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
Christian Kuhn commented on patch set 1 V 0 06/11/12, 16:16
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 06/11/12, 16:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4346/ : SUCCESS -
Christian Kuhn merged patch set 1 06/11/12, 16:16