Review main Merged

11924[TASK] CGL FunctionCallArgumentSpacingNoSpaceAfterComma in saltedpasswords

mostwanted CR +2 V +2 Easy +6 −6 updated 06/03/13, 20:49

Commit message

There are CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/saltedpasswords/.

These will be reduced.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 5

Review log 5

  1. Oliver Klee commented on patch set 1 06/11/12, 17:05

    Looks good to me, but someone else must approve
  2. mostwanted commented on patch set 1 06/11/12, 17:05

    This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors.
  3. Mr. Jenkins commented on patch set 1 06/11/12, 17:05

  4. Christian Kuhn commented on patch set 1 V 0 06/11/12, 17:05

    by team member; Looks good to me, approved
  5. Christian Kuhn merged patch set 1 06/11/12, 17:05