11928[BUGFIX] No version overlay should be done for sys_language
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Files 1
Review log 24
-
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve Hmm, how come I didn't notice that SQL-error until now? -
Stefan Neufeind uploaded patch set 3 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 3 05/27/13, 17:19
hand-rebased had 3x +1-by-review -
Lienhart Woitok uploaded patch set 2 05/27/13, 17:19
-
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve It is common to have the change-id line on top of Fixes, but it does not matter.class.tslib_fe.php:2349the comment is rather long, please split it -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
(1 inline comment) btw, Mr. Jenkens seems to be wrong today. -
Philipp Gampe commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4350/ : FAILURE -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4387/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6859/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Wouter Wolters uploaded patch set 4 05/28/13, 18:53
-
Mr. Jenkins commented on patch set 4 05/28/13, 18:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8910/ : SUCCESS -
Wouter Wolters voted on patch set 4 CR +1 07/29/13, 13:52
-
Stefan Neufeind voted on patch set 4 CR +1 08/05/13, 20:33
-
Stefan Galinski voted on patch set 4 V +1 08/08/13, 18:59
-
Christian Kuhn updated the commit message in patch set 4 08/08/13, 19:42
-
Mr. Jenkins commented on patch set 5 08/08/13, 19:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9968/ : SUCCESS -
Christian Kuhn commented on patch set 5 V +1 CR +1 08/08/13, 19:43
In general, this is only a workaround. The problem begins with the fact that this piece of code is dedicated to a specific extension (non-core) that is also not abstracted. I'd accept the workaround for now, though. -
Stefan Neufeind voted on patch set 5 CR +1 08/09/13, 10:07
-
Wouter Wolters voted on patch set 5 V +2 CR +2 08/20/13, 21:01
-
Wouter Wolters merged patch set 6 08/20/13, 21:01
-
Wouter Wolters commented on patch set 6 08/20/13, 21:02
Cherry Picked This patchset was cherry picked to change: I37be782601fc37e78a74d2459b6f246c5107b701 -
Wouter Wolters commented on patch set 6 08/20/13, 21:02
Cherry Picked This patchset was cherry picked to change: I37be782601fc37e78a74d2459b6f246c5107b701