11932[FEATURE] Make CSS for sysext form configurable
Commit message
Review
-
Code review CR +2
- Susi Moog +2
-
Verified V +2
- Susi Moog +2
Issues 1
Files 5
- typo3/sysext/form/Classes/View/Confirmation/Confirmation.php3+0 −14
- typo3/sysext/form/Classes/View/Form/Form.php+0 −14
- typo3/sysext/form/Configuration/TypoScript/setup.txt+207 −1
- typo3/sysext/form/Resources/Public/CSS/Confirmation.cssdeleted+0 −204
- typo3/sysext/form/Resources/Public/CSS/Form.cssdeleted+0 −204
Review log 33
Show 8 earlier messages
-
Marcus Schwemer commented on patch set 2 08/17/12, 17:06
Looks good to me, but someone else must approve -
Marcus Schwemer commented on patch set 2 08/17/12, 17:06
Verified; I would prefer that you didn't submit this Currently we have a discussion on the core list about naming conventions for TypoScript properties. At least for new properties there is common sense to use lowerCamelCase. So the "includeCSS" should be "includeCss". -
Oliver Hader commented on patch set 2 08/17/12, 17:06
Looks good to me, approved -
Lorenz Ulrich uploaded patch set 2 08/17/12, 17:06
-
Lorenz Ulrich uploaded patch set 3 08/17/12, 17:06
-
Marcus Schwemer commented on patch set 4 08/17/12, 17:06
Verified; Looks good to me, but someone else must approve -
Lorenz Ulrich uploaded patch set 4 08/17/12, 17:06
-
Lorenz Ulrich commented on patch set 4 08/17/12, 17:06
Following Marcus Schwermer's comment, the property is named "includeCss" instead of "includeCSS" now. No functional changes.
-
Lorenz Ulrich commented on patch set 4 08/17/12, 17:06
(1 inline comment) See inline comment. CGL stuff will be taken care of. -
Lorenz Ulrich commented on patch set 4 08/17/12, 17:06
(1 inline comment) Done. -
Marcus Schwemer commented on patch set 5 08/17/12, 17:06
Verified; Looks good to me, but someone else must approve Since it's only a CGL fix I gave my +1 for verified too. -
Marcus Schwemer commented on patch set 6 08/17/12, 17:06
I prefer the original approach of this patch. Why? Because this solutions requires more steps to get a individual styling and the connection between CSS and the ext itself is somewhat harder to find. Your solution: * set "_CSS_DEFAULT_STYLE >" * open setup.txt * text copy and save content of _CSS_DEFAULT_STYLE to your global css | extra css file * add the new file to page.includeCSS * edit css content Original Approach * file copy the css file to new location * change the css file location in TS of EXT:form * edit content Marcus -
Marcus Schwemer commented on patch set 6 08/17/12, 17:06
@Christian: What about changing all the other sysexts to this "new" way too? I was really happy to see this clean and easy way emerging. -
Susi Moog commented on patch set 6 V 0 08/17/12, 17:06
by team member; Looks good to me, approved Long term solution could be to rewrite the whole css handling for all extensions. -
Christian Kuhn commented on patch set 6 08/17/12, 17:06
Ah, Marcus with c, sorry 'bout that ... -
Christian Kuhn uploaded patch set 6 08/17/12, 17:06
-
Christian Kuhn commented on patch set 6 08/17/12, 17:06
The core already has an API to deliver, disable and manage default css by extensions. I wonder why ext:form didn't use this in the first place, but decided to hack up an own solution. The pushed version now switches to this API (and removes the identical Confirmation.css / Form.css) I like this approach better, what do you think? -
Christian Kuhn commented on patch set 6 08/17/12, 17:06
@Markus: You are correct, but my proposed solution is the core way other extensions like felogin and friends follow as well. I do not really like to break this way, if there is no good reason. -
Lorenz Ulrich uploaded patch set 5 08/17/12, 17:06
-
Lorenz Ulrich commented on patch set 5 08/17/12, 17:06
Only CGL fix. -
Lorenz Ulrich commented on patch set 6 08/17/12, 17:06
I can live with both of it, but I preferred the original approach because that way the Form extension's CSS is only loaded when there is a form on the current page. This is not supported by the default way TYPO3 is handling CSS. -
Mattias Nilsson commented on patch set 2 08/17/12, 17:06
Verified; Looks good to me, but someone else must approve -
Mattias Nilsson commented on patch set 5 08/17/12, 17:06
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 08/17/12, 17:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4355/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/17/12, 17:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4358/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/17/12, 17:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4883/ : SUCCESS -
Mr. Jenkins commented on patch set 5 08/17/12, 17:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4962/ : SUCCESS -
Mr. Jenkins commented on patch set 6 08/17/12, 17:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5091/ : SUCCESS -
Julian Wachholz commented on patch set 2 08/17/12, 17:06
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 4 08/17/12, 17:06
(2 inline comments) One CGL thing and one questionConfirmation.php:175missing confirmation. here? In Form it is like: !empty($this->typoscript['form.']['includeCss']Confirmation.php:175Replyok:)Abstract.php:78spaces around = -
Wouter Wolters commented on patch set 4 1 comment 08/17/12, 17:06
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 5 08/17/12, 17:06
Verified; Looks good to me, but someone else must approve -
Susi Moog merged patch set 6 08/17/12, 17:06