Review main Merged

11932[FEATURE] Make CSS for sysext form configurable

Lorenz Ulrich CR +2 V +2 Hard +207 −437 updated 06/03/13, 20:49

Commit message

Move the default styles of ext:form to TS in
plugin.tx_form._CSS_DEFAULT_STYLE. This way it can be disabled with
TypoScript either via plugin.tx_form._CSS_DEFAULT_STYLE >, and also
respects the config.removeDefaultCss setting.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2

Issues 1

Files 5

Review log 33

Show 8 earlier messages
  1. Marcus Schwemer commented on patch set 2 08/17/12, 17:06

    Looks good to me, but someone else must approve
  2. Marcus Schwemer commented on patch set 2 08/17/12, 17:06

    Verified; I would prefer that you didn't submit this Currently we have a discussion on the core list about naming conventions for TypoScript properties. At least for new properties there is common sense to use lowerCamelCase. So the "includeCSS" should be "includeCss".
  3. Oliver Hader commented on patch set 2 08/17/12, 17:06

    Looks good to me, approved
  4. Lorenz Ulrich uploaded patch set 2 08/17/12, 17:06

  5. Lorenz Ulrich uploaded patch set 3 08/17/12, 17:06

  6. Marcus Schwemer commented on patch set 4 08/17/12, 17:06

    Verified; Looks good to me, but someone else must approve
  7. Lorenz Ulrich uploaded patch set 4 08/17/12, 17:06

  8. Lorenz Ulrich commented on patch set 4 08/17/12, 17:06

    Following Marcus Schwermer's comment, the property is named "includeCss" instead of "includeCSS" now. No functional changes.
  1. Lorenz Ulrich commented on patch set 4 08/17/12, 17:06

    (1 inline comment) See inline comment. CGL stuff will be taken care of.
  2. Lorenz Ulrich commented on patch set 4 08/17/12, 17:06

    (1 inline comment) Done.
  3. Marcus Schwemer commented on patch set 5 08/17/12, 17:06

    Verified; Looks good to me, but someone else must approve Since it's only a CGL fix I gave my +1 for verified too.
  4. Marcus Schwemer commented on patch set 6 08/17/12, 17:06

    I prefer the original approach of this patch. Why? Because this solutions requires more steps to get a individual styling and the connection between CSS and the ext itself is somewhat harder to find. Your solution: * set "_CSS_DEFAULT_STYLE >" * open setup.txt * text copy and save content of _CSS_DEFAULT_STYLE to your global css | extra css file * add the new file to page.includeCSS * edit css content Original Approach * file copy the css file to new location * change the css file location in TS of EXT:form * edit content Marcus
  5. Marcus Schwemer commented on patch set 6 08/17/12, 17:06

    @Christian: What about changing all the other sysexts to this "new" way too? I was really happy to see this clean and easy way emerging.
  6. Susi Moog commented on patch set 6 V 0 08/17/12, 17:06

    by team member; Looks good to me, approved Long term solution could be to rewrite the whole css handling for all extensions.
  7. Christian Kuhn commented on patch set 6 08/17/12, 17:06

    Ah, Marcus with c, sorry 'bout that ...
  8. Christian Kuhn uploaded patch set 6 08/17/12, 17:06

  9. Christian Kuhn commented on patch set 6 08/17/12, 17:06

    The core already has an API to deliver, disable and manage default css by extensions. I wonder why ext:form didn't use this in the first place, but decided to hack up an own solution. The pushed version now switches to this API (and removes the identical Confirmation.css / Form.css) I like this approach better, what do you think?
  10. Christian Kuhn commented on patch set 6 08/17/12, 17:06

    @Markus: You are correct, but my proposed solution is the core way other extensions like felogin and friends follow as well. I do not really like to break this way, if there is no good reason.
  11. Lorenz Ulrich uploaded patch set 5 08/17/12, 17:06

  12. Lorenz Ulrich commented on patch set 5 08/17/12, 17:06

    Only CGL fix.
  13. Lorenz Ulrich commented on patch set 6 08/17/12, 17:06

    I can live with both of it, but I preferred the original approach because that way the Form extension's CSS is only loaded when there is a form on the current page. This is not supported by the default way TYPO3 is handling CSS.
  14. Mattias Nilsson commented on patch set 2 08/17/12, 17:06

    Verified; Looks good to me, but someone else must approve
  15. Mattias Nilsson commented on patch set 5 08/17/12, 17:06

    Verified; Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 1 08/17/12, 17:06

  17. Mr. Jenkins commented on patch set 2 08/17/12, 17:06

  18. Mr. Jenkins commented on patch set 4 08/17/12, 17:06

  19. Mr. Jenkins commented on patch set 5 08/17/12, 17:06

  20. Mr. Jenkins commented on patch set 6 08/17/12, 17:06

  21. Julian Wachholz commented on patch set 2 08/17/12, 17:06

    Verified; Looks good to me, but someone else must approve
  22. Wouter Wolters commented on patch set 4 08/17/12, 17:06

    (2 inline comments) One CGL thing and one question

    Confirmation.php:175

    missing confirmation. here? In Form it is like: !empty($this->typoscript['form.']['includeCss']

    Confirmation.php:175 Reply

    ok:)

    Abstract.php:78

    spaces around =
  23. Wouter Wolters commented on patch set 4 1 comment 08/17/12, 17:06

    Looks good to me, but someone else must approve
  24. Wouter Wolters commented on patch set 5 08/17/12, 17:06

    Verified; Looks good to me, but someone else must approve
  25. Susi Moog merged patch set 6 08/17/12, 17:06