Review main Merged

11948CGL FunctionCallArgumentSpacingNoSpaceAfterComma in setup

Ludwig Rafelsberger CR +2 V +2 Easy +7 −7 updated 06/03/13, 20:49

Commit message

Fix CGL violations against FunctionCallArgumentSpacingNoSpaceAfterComma
in /typo3/sysext/setup.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • mostwanted +1
    • Hauser Obadja +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 5

  1. mostwanted commented on patch set 1 06/11/12, 20:34

    Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 V 0 06/11/12, 20:34

    by team member; Looks good to me, approved Ha, even more CGL patch submitters! Looks like there will be no unchanged file in 6.0 and everything will be more shiny, readable and streamlined. Thanks for the patch, it is always good to see new submitters. Keep up the work and feel free to prove and review other patches on logical, codewise and functional correctness as well. Merged.
  3. Mr. Jenkins commented on patch set 1 06/11/12, 20:34

  4. Hauser Obadja commented on patch set 1 06/11/12, 20:34

    Looks good to me, but someone else must approve
  5. Christian Kuhn merged patch set 1 06/11/12, 20:34