Review main Merged

11971[TASK] Clean up phpDoc comments in typo3/

Wouter Wolters CR +2 V +2 Hard +180 −167 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* typo3/class.file_list.inc
* typo3/class.filelistfoldertree.php
* typo3/class.show_rechis.inc

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 3

Review log 7

  1. Christian Kuhn commented on patch set 1 06/12/12, 07:09

    I would prefer that you didn't submit this in class.file_list.inc several tab before '{' are inserted instead of a whitespace.

    class.file_list.inc:185

    tab inserted before { ?
  2. Mr. Jenkins commented on patch set 1 06/12/12, 07:09

  3. Wouter Wolters commented on patch set 1 06/12/12, 07:09

    My fault, mixed this up with a wrong file while working on this. Will resubmit tomorrow.
  4. Christian Kuhn commented on patch set 2 V 0 06/12/12, 07:09

    by team member; Looks good to me, approved
  5. Mr. Jenkins commented on patch set 2 06/12/12, 07:09

  6. Wouter Wolters uploaded patch set 2 06/12/12, 07:09

  7. Christian Kuhn merged patch set 2 06/12/12, 07:09