Review main Merged

11999[TASK] Clean up phpDoc comments in typo3/

Wouter Wolters CR +2 V +2 Hard +304 −311 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* typo3/class.webpagetree.php
* typo3/cleaner_check.sh
* typo3/cleaner_fix.sh
* typo3/cli_dispatch.phpsh
* typo3/db_new.php
* typo3/dummy.php
* typo3/file_edit.php
* typo3/file_newfolder.php
* typo3/file_rename.php
* typo3/file_upload.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 10

Review log 8

  1. Oliver Klee commented on patch set 1 06/14/12, 21:20

    I would prefer that you didn't submit this

    class.webpagetree.php:317

    for $isExpand: string -> boolean

    class.webpagetree.php:402

    Here, you've merged two @param into one. :-)
  2. Mr. Jenkins commented on patch set 1 06/14/12, 21:20

  3. Oliver Klee commented on patch set 2 06/14/12, 21:20

    Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 2 06/14/12, 21:20

  5. Wouter Wolters commented on patch set 2 06/14/12, 21:20

    Fixed the comments
  6. Wouter Wolters uploaded patch set 2 06/14/12, 21:20

  7. Christian Kuhn commented on patch set 2 V 0 06/14/12, 21:20

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 06/14/12, 21:20