12001[TASK] CGL FunctionCallArgumentSpacingNoSpaceAfterComma in /typo3/
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Galinski +1
-
Verified V +2
- Christian Kuhn +2
- Stefan Galinski +1
Issues 1
Files 16
- typo3/alt_clickmenu.php+5 −5
- typo3/alt_doc.php+2 −2
- typo3/alt_shortcut.php+1 −1
- typo3/Bootstrap.php+2 −2
- typo3/class.browse_links.php+15 −8
- typo3/class.show_rechis.inc+7 −7
- typo3/class.webpagetree.php+1 −1
- typo3/show_item.php+1 −1
- typo3/template.php+1 −1
- typo3/view_help.php+3 −3
- typo3/wizard_colorpicker.php+2 −2
- typo3/wizard_forms.php+8 −8
- typo3/wizard_list.php+1 −1
- typo3/wizard_rte.php+1 −1
- typo3/wizard_table.php+5 −5
- typo3/wizard_tsconfig.php+8 −8
Review log 10
-
Oliver Klee commented on patch set 2 06/14/12, 20:54
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 3 06/14/12, 20:54
Looks good to me, but someone else must approve -
Stefan Galinski uploaded patch set 3 06/14/12, 20:54
-
Stefan Galinski commented on patch set 3 06/14/12, 20:54
Verified; Looks good to me, but someone else must approve fixed some more CGL issues on the already touched lines; testing by "php -l" -
mostwanted uploaded patch set 2 06/14/12, 20:54
-
Mr. Jenkins commented on patch set 1 06/14/12, 20:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4398/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/14/12, 20:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4399/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/14/12, 20:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4419/ : SUCCESS -
Christian Kuhn commented on patch set 3 V 0 06/14/12, 20:54
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 06/14/12, 20:54