Review main Merged

12041[TASK] Fix CGL violations against DoubleQuoteUsage

Ludwig Rafelsberger CR +2 V +2 Normal +87 −87 updated 06/03/13, 20:49

Commit message

Some violations against other CGL rules have been fixed as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Xavier Perseguers +1
  • Verified V +2
    • Christian Kuhn +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 10

  1. Xavier Perseguers uploaded patch set 2 06/14/12, 20:47

  2. Oliver Klee commented on patch set 3 06/14/12, 20:47

    Looks good to me, but someone else must approve
  3. Xavier Perseguers commented on patch set 3 06/14/12, 20:47

    Verified; Looks good to me, but someone else must approve
  4. Xavier Perseguers uploaded patch set 3 06/14/12, 20:47

  5. Mr. Jenkins commented on patch set 1 06/14/12, 20:47

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4421/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 06/14/12, 20:47

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4423/ : FAILURE
  7. Mr. Jenkins commented on patch set 3 06/14/12, 20:47

  8. Wouter Wolters commented on patch set 2 06/14/12, 20:47

    Line exceeds maximum length of 74 characters (length: 86) : see https://ci.typo3.org/job/typo3-v4-core-gerrit/4423/console
  9. Christian Kuhn commented on patch set 3 V 0 06/14/12, 20:47

    by team member; Looks good to me, approved
  10. Christian Kuhn merged patch set 3 06/14/12, 20:47