Review main Merged

12068[TASK] Clean up phpDoc comments in typo3/sysext/

Wouter Wolters CR +2 V +2 Hard +389 −360 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* typo3/sysext/about/interfaces/interface.tx_about_customsections.php
* typo3/sysext/aboutmodules/class.tx_aboutmodules_functions.php
* typo3/sysext/adodb/checkconnectionwizard.php
* typo3/sysext/adodb/class.tx_adodb_tceforms.php
* typo3/sysext/adodb/ext_localconf.php
* typo3/sysext/adodb/locallang_datasource_config.xlf
* typo3/sysext/adodb/locallang_wizard.xlf
* typo3/sysext/cms/classes/class.tx_cms_backendlayout.php
* typo3/sysext/cms/layout/class.tx_cms_layout.php
* typo3/sysext/cms/layout/interfaces/
	interface.tx_cms_layout_tt_content_drawitemhook.php
* typo3/sysext/cms/layout/res/typo3.pageModule.js

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 11

Review log 8

  1. Oliver Klee commented on patch set 1 06/14/12, 21:52

    I would prefer that you didn't submit this

    ext_localconf.php:3

    The spaces after "defined" and after "die" should go.

    class.tx_cms_layout.php:357

    missing parameter name

    class.tx_cms_layout.php:1235

    boolea -> boolean

    class.tx_cms_layout.php:1707

    pointer -> resource

    class.tx_cms_layout.php:2161

    missing parameter name

    class.tx_cms_layout.php:2233

    two parameter names missing
  2. Mr. Jenkins commented on patch set 1 06/14/12, 21:52

  3. Wouter Wolters commented on patch set 1 06/14/12, 21:52

    Fixed the comments
  4. Oliver Klee commented on patch set 2 06/14/12, 21:52

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 2 06/14/12, 21:52

  6. Wouter Wolters uploaded patch set 2 06/14/12, 21:52

  7. Christian Kuhn commented on patch set 2 V 0 06/14/12, 21:52

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 06/14/12, 21:52