12068[TASK] Clean up phpDoc comments in typo3/sysext/
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 11
- typo3/sysext/about/interfaces/interface.tx_about_customsections.php+1 −1
- typo3/sysext/aboutmodules/class.tx_aboutmodules_functions.php+1 −1
- typo3/sysext/adodb/checkconnectionwizard.php+7 −6
- typo3/sysext/adodb/class.tx_adodb_tceforms.php+17 −7
- typo3/sysext/adodb/ext_localconf.php1+5 −3
- typo3/sysext/adodb/locallang_datasource_config.xlf+1 −1
- typo3/sysext/adodb/locallang_wizard.xlf+1 −1
- typo3/sysext/cms/classes/class.tx_cms_backendlayout.php+9 −9
- typo3/sysext/cms/layout/interfaces/interface.tx_cms_layout_tt_content_drawitemhook.php+9 −9
- typo3/sysext/cms/layout/res/typo3.pageModule.js+1 −1
- typo3/sysext/cms/layout/class.tx_cms_layout.php5+337 −321
Review log 8
-
Oliver Klee commented on patch set 1 06/14/12, 21:52
I would prefer that you didn't submit thisext_localconf.php:3The spaces after "defined" and after "die" should go.class.tx_cms_layout.php:357missing parameter nameclass.tx_cms_layout.php:1235boolea -> booleanclass.tx_cms_layout.php:1707pointer -> resourceclass.tx_cms_layout.php:2161missing parameter nameclass.tx_cms_layout.php:2233two parameter names missing -
Mr. Jenkins commented on patch set 1 06/14/12, 21:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4427/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/14/12, 21:52
Fixed the comments -
Oliver Klee commented on patch set 2 06/14/12, 21:52
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 06/14/12, 21:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4431/ : SUCCESS -
Wouter Wolters uploaded patch set 2 06/14/12, 21:52
-
Christian Kuhn commented on patch set 2 V 0 06/14/12, 21:52
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 2 06/14/12, 21:52