Review TYPO3_4-5 Merged

12079[BUGFIX] CE with "All languages" isn't shown in Page module

Markus Klein CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

The page module should also list the content elements
with language set to "All"

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Marcus Schwemer +1
  • Verified V +2
    • Steffen Ritter +2
    • Marcus Schwemer +1

Issues 1

Files 1

Review log 9

  1. Marcus Schwemer commented on patch set 1 10/14/12, 16:20

    I would prefer that you didn't submit this in this case CE set for "all languages" are only displayed with the default language, but not with other translations.
  2. Marcus Schwemer uploaded patch set 2 10/14/12, 16:20

  3. Marcus Schwemer uploaded patch set 3 10/14/12, 16:20

  4. Marcus Schwemer commented on patch set 3 10/14/12, 16:20

    Verified; Looks good to me, but someone else must approve This is the "original" patch from Georg again. There will be a follow-up to this issue. Currently it is possible to review the f'up for master (same topic).
  5. Markus Klein commented on patch set 2 10/14/12, 16:20

    Marcus, please check if this also happens in current master. If so, please merge this as is and file a new patchset for master - 4.5
  6. Markus Klein commented on patch set 2 10/14/12, 16:20

    I would prefer that you didn't submit this Marcus, please check if this also happens in current master. If so, please merge this as is and file a new patchset for master - 4.5
  7. Mattias Nilsson commented on patch set 2 10/14/12, 16:20

    Verified; Looks good to me, but someone else must approve
  8. Steffen Ritter commented on patch set 3 V 0 10/14/12, 16:20

    by team member; Looks good to me, approved
  9. Steffen Ritter merged patch set 3 10/14/12, 16:20