Review TYPO3_4-7 Merged

12080[BUGFIX] CE with "All languages" isn't shown in Page module

Markus Klein CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

The page module should also list the content elements
with language set to "All"

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Markus Klein +1
    • Heiko Kromm +1
  • Verified V +2
    • Steffen Ritter +2
    • Markus Klein +1
    • Heiko Kromm +1

Issues 1

Files 1

Review log 9

  1. Marcus Schwemer commented on patch set 1 10/12/12, 13:21

    Verified; Looks good to me, but someone else must approve
  2. Marcus Schwemer commented on patch set 1 10/12/12, 13:21

    Hi Steffen any updates on this? I would like to get this in and take care of the backports of the other patches . Regards, Marcus
  3. Markus Klein commented on patch set 1 10/12/12, 13:21

    Hi Steffen, we talked on the Core list about that. Afaik the decision was to merge all these backports and continue with https://review.typo3.org/12185 seperately.
  4. Markus Klein uploaded patch set 2 10/12/12, 13:21

  5. Markus Klein commented on patch set 2 10/12/12, 13:21

    Verified; Looks good to me, but someone else must approve Rebased. Please merge and continue with https://review.typo3.org/#/q/topic:24087,n,z
  6. Steffen Ritter commented on patch set 1 10/12/12, 13:21

    I would prefer that you didn't submit this There already is a newer version for master branch
  7. Heiko Kromm commented on patch set 2 10/12/12, 13:21

    Verified; Looks good to me, but someone else must approve
  8. Steffen Ritter commented on patch set 2 V 0 10/12/12, 13:21

    by team member; Looks good to me, approved
  9. Steffen Ritter merged patch set 2 10/12/12, 13:21