12091[TASK] Replace duplicate code with a bootstrap method call
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 3
Review log 11
-
Helmut Hummel uploaded patch set 2 06/15/12, 12:59
-
Oliver Klee commented on patch set 3 06/15/12, 12:59
(3 inline comments)class.tslib_fe.php:2089Now that we have this well-named method, we don't need this comment anymore.class.tx_install.php:7519Now that we have this well-named method, we don't need this comment anymore.class.tx_coreupdates_migrateworkspaces.php:391Now that we have this well-named method, we don't need this comment anymore. -
Oliver Klee uploaded patch set 4 06/15/12, 12:59
-
Oliver Klee commented on patch set 4 06/15/12, 12:59
Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 3 06/15/12, 12:59
-
Mr. Jenkins commented on patch set 1 06/15/12, 12:59
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4436/ : FAILURE -
Mr. Jenkins commented on patch set 2 06/15/12, 12:59
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4437/ : FAILURE -
Mr. Jenkins commented on patch set 3 06/15/12, 12:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4438/ : SUCCESS -
Mr. Jenkins commented on patch set 4 06/15/12, 12:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4441/ : SUCCESS -
Christian Kuhn commented on patch set 4 V 0 06/15/12, 12:59
by team member; Looks good to me, approved Merged as nearly no-brainer. -
Christian Kuhn merged patch set 4 06/15/12, 12:59