Review main Merged

12091[TASK] Replace duplicate code with a bootstrap method call

Helmut Hummel CR +2 V +2 Easy +3 −33 updated 06/03/13, 20:49

Commit message

The ext_tables inclusion hook has been moved to a
method in the bootstrap class. Use this bootstrap method
instead of duplicating the hook code in several places.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 3

Review log 11

  1. Helmut Hummel uploaded patch set 2 06/15/12, 12:59

  2. Oliver Klee commented on patch set 3 06/15/12, 12:59

    (3 inline comments)

    class.tslib_fe.php:2089

    Now that we have this well-named method, we don't need this comment anymore.

    class.tx_install.php:7519

    Now that we have this well-named method, we don't need this comment anymore.

    class.tx_coreupdates_migrateworkspaces.php:391

    Now that we have this well-named method, we don't need this comment anymore.
  3. Oliver Klee uploaded patch set 4 06/15/12, 12:59

  4. Oliver Klee commented on patch set 4 06/15/12, 12:59

    Looks good to me, but someone else must approve
  5. Helmut Hummel uploaded patch set 3 06/15/12, 12:59

  6. Mr. Jenkins commented on patch set 1 06/15/12, 12:59

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4436/ : FAILURE
  7. Mr. Jenkins commented on patch set 2 06/15/12, 12:59

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4437/ : FAILURE
  8. Mr. Jenkins commented on patch set 3 06/15/12, 12:59

  9. Mr. Jenkins commented on patch set 4 06/15/12, 12:59

  10. Christian Kuhn commented on patch set 4 V 0 06/15/12, 12:59

    by team member; Looks good to me, approved Merged as nearly no-brainer.
  11. Christian Kuhn merged patch set 4 06/15/12, 12:59