12092[TASK] Fix CGL violations DoubleQuoteUsage
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 3
Review log 8
-
Oliver Klee commented on patch set 1 06/20/12, 21:11
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 1 06/20/12, 21:11
(1 inline comment) -
Christian Kuhn uploaded patch set 2 06/20/12, 21:11
-
Mr. Jenkins commented on patch set 1 06/20/12, 21:11
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4439/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/20/12, 21:11
I would prefer that you didn't submit this Please see inline commentclass.tx_rtehtmlarea_base.php:745This looks weird. Now you have a string: '$1-$2$3' Think this needs to be $1 . '-' . $2 . $3class.tx_rtehtmlarea_base.php:745ReplyMy bad, now I see it is used in preg_replace... -
Wouter Wolters commented on patch set 1 1 comment 06/20/12, 21:11
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 2 V 0 06/20/12, 21:11
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 2 06/20/12, 21:11