Review main Merged

12092[TASK] Fix CGL violations DoubleQuoteUsage

Ludwig Rafelsberger CR +2 V +2 Normal +69 −65 updated 06/03/13, 20:49

Commit message

Fixed some other CGL violations too.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 3

Review log 8

  1. Oliver Klee commented on patch set 1 06/20/12, 21:11

    Looks good to me, but someone else must approve
  2. Oliver Klee commented on patch set 1 06/20/12, 21:11

    (1 inline comment)
  3. Christian Kuhn uploaded patch set 2 06/20/12, 21:11

  4. Mr. Jenkins commented on patch set 1 06/20/12, 21:11

  5. Wouter Wolters commented on patch set 1 06/20/12, 21:11

    I would prefer that you didn't submit this Please see inline comment

    class.tx_rtehtmlarea_base.php:745

    This looks weird. Now you have a string: '$1-$2$3' Think this needs to be $1 . '-' . $2 . $3

    class.tx_rtehtmlarea_base.php:745 Reply

    My bad, now I see it is used in preg_replace...
  6. Wouter Wolters commented on patch set 1 1 comment 06/20/12, 21:11

    Looks good to me, but someone else must approve
  7. Christian Kuhn commented on patch set 2 V 0 06/20/12, 21:11

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 06/20/12, 21:11