Review main Merged

12107[TASK] Clean up phpDoc comments in typo3/sysext/

Wouter Wolters CR +2 V +2 Hard +121 −158 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_content_cobjgetsinglehook.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_content_fileLinkHook.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_content_getPublicUrlForFileHook.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_content_getdatahook.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_content_getimgresourcehook.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_content_postinithook.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_content_stdwraphook.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_mediawizardprovider.php
* typo3/sysext/cms/tslib/interfaces/
	interface.tslib_menu_filterMenuPagesHook.php
* typo3/sysext/cms/tslib/media/scripts/example_callfunction.php
* typo3/sysext/cms/tslib/media/scripts/example_itemArrayProcFunc.php
* typo3/sysext/cms/tslib/media/scripts/example_keepRollover.js
* typo3/sysext/cms/tslib/media/scripts/example_keepRollover.php
* typo3/sysext/cms/tslib/media/scripts/example_languageMenu.php
* typo3/sysext/cms/tslib/media/scripts/example_typolinkpop.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 15

Review log 10

  1. Mr. Jenkins commented on patch set 1 06/20/12, 21:14

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4457/ : FAILURE
  2. Oliver Klee commented on patch set 2 06/20/12, 21:14

    (1 inline comment)

    example_callfunction.php:99

    missing parameter names
  3. Mr. Jenkins commented on patch set 2 06/20/12, 21:14

  4. Wouter Wolters uploaded patch set 2 06/20/12, 21:14

  5. Oliver Klee commented on patch set 3 06/20/12, 21:14

    Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 3 06/20/12, 21:14

  7. Wouter Wolters uploaded patch set 3 06/20/12, 21:14

  8. Wouter Wolters commented on patch set 3 06/20/12, 21:14

    Inline comment fixed
  9. Christian Kuhn commented on patch set 3 V 0 06/20/12, 21:14

    by team member; Looks good to me, approved
  10. Christian Kuhn merged patch set 3 06/20/12, 21:14