Review main Abandoned

12120[BUGFIX] Multiple domain records in one tree are not supported

Nicole Hummel CR 0 V 0 Easy +12 −2 updated 07/16/15, 09:55

Commit message

The link to a page with its own domain record is not generated
correctly. For the page with the domain record it's important
to remove the URL as otherwise there might be some error in
fetching the id.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 14

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    @Christian: I understand this patch tries to address that. What other problems are to be expected maybe, that could also be addressed in this patch?
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve seems to make sense to me by reading code and Nicole's explanation
  3. Christian Kuhn commented on patch set 1 05/27/13, 17:19

    Be aware that nested domain records are not supported by TYPO3 anyway. Doing so will probably lead to further problems.
  4. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  5. Nicole Hummel commented on patch set 1 05/27/13, 17:19

    The only way that is changed by this patch is the handling of the start page link. So I don't see any other issues might be happen.
  6. Stefan Neufeind updated the commit message in patch set 1 01/24/14, 00:16

  7. Stefan Neufeind voted on patch set 2 CR +1 01/24/14, 00:16

  8. Mr. Jenkins commented on patch set 2 CR -1 V -1 01/24/14, 00:31

  9. Markus Klein commented on patch set 2 01/24/14, 07:40

    class.tslib_content.php:6086

    ===
  10. Markus Klein commented on patch set 2 03/26/14, 21:15

    Still a topic? If so please fix that in the correct file now.
  11. Mathias Schreiber wrote 12/14/14, 16:33

    Topic changed from 38108 to Frontend
  12. Stephan Großberndt commented on patch set 2 CR -1 06/22/15, 13:54

    class.tslib_content.php:5949

    The whole fetching of $foundDomains is no longer in the typoLink() function, thus an easy rebase to typo3\sysext\frontend\Classes\ContentObject\ContentObjectRenderer.php is not possible.
  13. Helmut Hummel commented on patch set 2 07/14/15, 11:05

    Is this still an issue to be fixed in current master?
  14. Nicole Hummel abandoned the change 07/16/15, 09:55

    This is still an issue for out clients but maybe we have to find a different solution.