Review main Merged

12129[TASK] Clean up phpDoc comments in typo3/sysext/

Wouter Wolters CR +2 V +2 Expert +1051 −979 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* typo3/sysext/cms/tslib/class.tslib_adminpanel.php
* typo3/sysext/cms/tslib/class.tslib_content.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 9

  1. Oliver Klee commented on patch set 2 06/20/12, 20:52

    (7 inline comments)

    class.tslib_adminpanel.php:379

    mixed -> array

    class.tslib_content.php:1089

    @return void is missing.

    class.tslib_content.php:3866

    The special characters her in Kasper's last name seem to be broken.

    class.tslib_content.php:4532

    tab -> space

    class.tslib_content.php:4533

    tab -> space

    class.tslib_content.php:7213

    Uid -> UID

    class.tslib_content.php:7360

    id -> ID
  2. Mr. Jenkins commented on patch set 2 06/20/12, 20:52

  3. Wouter Wolters uploaded patch set 2 06/20/12, 20:52

  4. Wouter Wolters commented on patch set 2 06/20/12, 20:52

    Big one:)
  5. Mr. Jenkins commented on patch set 3 06/20/12, 20:52

  6. Wouter Wolters commented on patch set 3 06/20/12, 20:52

    Thanks for the review. Fixed your comments
  7. Wouter Wolters uploaded patch set 3 06/20/12, 20:52

  8. Christian Kuhn commented on patch set 3 V 0 06/20/12, 20:52

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 3 06/20/12, 20:52