Review main Merged

12142[TASK] Remove require statements for classes

Benni Mack CR +2 V +2 Normal +47 −143 updated 06/03/13, 20:49

Commit message

Since the autoloader is in place, the require statements for
all classes (including template.php) is not necessary.

This patch adds the core classes to the autoloader file,
and removes all unnecessary require statements.
This change also brings modification with that moves the
initialization of $GLOBALS['TBE_TEMPLATE'] from template.php
into init.php. This means that TBE_TEMPLATE is always
available in the backend now.

Review

  • Code review CR +2
    • Steffen Ritter +2
  • Verified V +2
    • Steffen Ritter +2

Issues 1

Files 65

Show 45 more files

Review log 14

  1. Steffen Ritter merged patch set 1 06/22/12, 10:13

  2. Mr. Jenkins commented on patch set 1 06/22/12, 10:13

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4505/ : FAILURE
  3. Steffen Ritter commented on patch set 2 V 0 1 comment 06/22/12, 10:13

    by team member; Looks good to me, approved will fix the CGL issue I noted and merge the new version than.
  4. Steffen Ritter uploaded patch set 3 06/22/12, 10:13

  5. Steffen Ritter commented on patch set 3 06/22/12, 10:13

    Do not submit grr - init.php merge missing
  6. Steffen Ritter uploaded patch set 4 06/22/12, 10:13

  7. Steffen Ritter commented on patch set 4 06/22/12, 10:13

    Reverted This patchset was reverted in change: I95839a52734f3c4fccb6aa4f23bf6d74b2359769
  8. Steffen Ritter commented on patch set 4 V 0 06/22/12, 10:13

    by team member; Looks good to me, approved
  9. Steffen Ritter commented on patch set 4 06/22/12, 10:13

    Reverted This patchset was reverted in change: Iee429e42354239c1815e0ee9d5757406c82c89cb
  10. Philipp Gampe commented on patch set 2 V 0 06/22/12, 10:13

    Tested by clicking around in the backend.

    core_autoload.php:314

    should be $typo3CoreClasses

    core_autoload.php:317

    this one is included via require and must never be included twice?
  11. Philipp Gampe commented on patch set 2 2 comments 06/22/12, 10:13

    Looks good to me, but someone else must approve
  12. Mr. Jenkins commented on patch set 2 06/22/12, 10:13

  13. Wouter Wolters uploaded patch set 2 06/22/12, 10:13

  14. Oliver Hader commented on patch set 3 06/22/12, 10:13

    Regression e.g. for missing class definitions to class.browse_links.php - this PHP file has multiple class definitions...