Review main Merged

12145[BUGFIX] Apc Cache backend has side effects

Daniel Poetzinger CR +2 V +2 Normal +82 −15 updated 06/03/13, 20:49

Commit message

If two caches use the APC cache backend,
one cache can write and get entries from the
 other by just using the same key!
So the backend should also use cache id as prefix

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
  • Verified V +2
    • Helmut Hummel +2

Files 2

Review log 26

Show 1 earlier messages
  1. Oliver Klee commented on patch set 1 01/11/13, 21:53

    This should be covered by a unit test.
  1. Schmidt Timo uploaded patch set 2 01/11/13, 21:53

  2. Schmidt Timo uploaded patch set 3 01/11/13, 21:53

  3. Schmidt Timo uploaded patch set 4 01/11/13, 21:53

  4. Ernesto Baschny commented on patch set 5 01/11/13, 21:53

    Fails; Do not submit Please do not commit submodule pointer changes with your changes! Make sure you base your commit on the head of origin of the branch you are applying (in this case, master).
  5. Schmidt Timo uploaded patch set 5 01/11/13, 21:53

  6. Christian Kuhn commented on patch set 6 01/11/13, 21:53

    @Ernesto: The submodule pointer change was fixed. Would you like to remove your -2 ?
  7. Schmidt Timo uploaded patch set 6 01/11/13, 21:53

  8. Philipp Gampe commented on patch set 1 01/11/13, 21:53

    Looks good to me, but someone else must approve A unit test should be pretty simple to write. There are already examples for this.
  9. Tymoteusz Motylewski commented on patch set 1 01/11/13, 21:53

    Looks good to me, but someone else must approve
  10. Tymoteusz Motylewski commented on patch set 6 01/11/13, 21:53

    Verified; Looks good to me, but someone else must approve
  11. Tymoteusz Motylewski commented on patch set 7 01/11/13, 21:53

    Just rebased to current master.
  12. Tymoteusz Motylewski uploaded patch set 7 01/11/13, 21:53

  13. Stefan Neufeind commented on patch set 8 01/11/13, 21:53

    Looks good to me, but someone else must approve
  14. Helmut Hummel commented on patch set 8 V 0 01/11/13, 21:53

    by team member; Looks good to me, approved
  15. Tymoteusz Motylewski uploaded patch set 8 01/11/13, 21:53

  16. Mr. Jenkins commented on patch set 1 01/11/13, 21:53

  17. Mr. Jenkins commented on patch set 2 01/11/13, 21:53

  18. Mr. Jenkins commented on patch set 3 01/11/13, 21:53

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4971/ : FAILURE
  19. Mr. Jenkins commented on patch set 4 01/11/13, 21:53

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4973/ : FAILURE
  20. Mr. Jenkins commented on patch set 5 01/11/13, 21:53

  21. Mr. Jenkins commented on patch set 6 01/11/13, 21:53

  22. Mr. Jenkins commented on patch set 7 01/11/13, 21:53

  23. Mr. Jenkins commented on patch set 8 01/11/13, 21:53

  24. Wouter Wolters commented on patch set 6 01/11/13, 21:53

    Verified; Looks good to me, but someone else must approve Verified with the unit-test
  25. Helmut Hummel merged patch set 9 01/11/13, 21:53