Review main Merged

12234[TASK] Clean up php doc headers in pageRenderer

Helmut Hummel CR +2 V +2 Hard +338 −90 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 7

  1. Christian Kuhn commented on patch set 2 V 0 06/20/12, 20:33

    by team member; Looks good to me, approved change all bool to boolean. Merged as no-brainer.
  2. Christian Kuhn uploaded patch set 2 06/20/12, 20:33

  3. Mr. Jenkins commented on patch set 1 06/20/12, 20:33

  4. Mr. Jenkins commented on patch set 2 06/20/12, 20:33

  5. Wouter Wolters commented on patch set 1 06/20/12, 20:33

    (1 inline comment)

    class.t3lib_pagerenderer.php:50

    I´d prefer boolean here. In phpDoc notation for function it is also boolean. What do you think?
  6. Ryan J. Peterson commented on patch set 1 06/20/12, 20:33

    Verified; Looks good to me, but someone else must approve
  7. Christian Kuhn merged patch set 2 06/20/12, 20:33