Review main Merged

12242[BUGFIX] Refactor page renderer

Helmut Hummel CR +2 V +2 Hard +397 −233 updated 06/03/13, 20:49

Commit message

The render method of the page renderer is huge and needs to be refactored
into smaller pieces to be able to integrate further changes.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 25

  1. Mr. Jenkins commented on patch set 1 06/23/12, 16:25

  2. Wouter Wolters commented on patch set 1 06/23/12, 16:25

    I would prefer that you didn't submit this New patch is on it's way.

    class.t3lib_pagerenderer.php:381

    XHTML I guess here

    class.t3lib_pagerenderer.php:1792

    Indention of inline comments one tab more.

    class.t3lib_pagerenderer.php:1796

    Same here

    class.t3lib_pagerenderer.php:1990

    Double space here

    class.t3lib_pagerenderer.php:2019

    Double space here

    class.t3lib_pagerenderer.php:2040

    Double space here
  3. Helmut Hummel commented on patch set 2 06/23/12, 16:25

    Thanks Wouter!
  4. Helmut Hummel commented on patch set 2 06/23/12, 16:25

    (1 inline comment)
  5. Markus Klein commented on patch set 3 06/23/12, 16:25

    (2 inline comments)
  6. Oliver Klee commented on patch set 3 06/23/12, 16:25

    (1 inline comment)
  7. Oliver Klee commented on patch set 3 06/23/12, 16:25

    (2 inline comments)
  8. Helmut Hummel commented on patch set 3 06/23/12, 16:25

    (1 inline comment)
  9. Helmut Hummel uploaded patch set 3 06/23/12, 16:25

  10. Christian Kuhn commented on patch set 3 06/23/12, 16:25

    will review today
  11. Christian Kuhn commented on patch set 3 06/23/12, 16:25

    (6 inline comments)
  12. Christian Kuhn uploaded patch set 4 06/23/12, 16:25

  13. Christian Kuhn commented on patch set 4 06/23/12, 16:25

    Verified; Looks good to me, but someone else must approve
  14. Steffen Ritter commented on patch set 2 06/23/12, 16:25

    (1 inline comment) Hi Helmut, a good step in the correct direction. One thing I would like to you to comment there. Please see my inline comment.
  15. Steffen Ritter commented on patch set 3 06/23/12, 16:25

    Verified; Looks good to me, but someone else must approve at least my Default use cases seem to work
  16. Philipp Gampe voted on patch set 3 V 0 06/23/12, 16:25

  17. Philipp Gampe commented on patch set 3 06/23/12, 16:25

    Looks good to me, but someone else must approve
  18. Philipp Gampe commented on patch set 4 06/23/12, 16:25

    Verified; Looks good to me, but someone else must approve
  19. Felix Kopp commented on patch set 3 06/23/12, 16:25

    Looks good to me, but someone else must approve
  20. Felix Kopp commented on patch set 3 4 comments 06/23/12, 16:25

    No score
  21. Felix Kopp voted on patch set 3 V 0 06/23/12, 16:25

  22. Mr. Jenkins commented on patch set 4 06/23/12, 16:25

  23. Wouter Wolters uploaded patch set 2 06/23/12, 16:25

  24. Christian Kuhn commented on patch set 4 V 0 06/23/12, 16:25

    by team member; Looks good to me, approved
  25. Christian Kuhn merged patch set 4 06/23/12, 16:25