12242[BUGFIX] Refactor page renderer
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 25
-
Mr. Jenkins commented on patch set 1 06/23/12, 16:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4545/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/23/12, 16:25
I would prefer that you didn't submit this New patch is on it's way.class.t3lib_pagerenderer.php:381XHTML I guess hereclass.t3lib_pagerenderer.php:1792Indention of inline comments one tab more.class.t3lib_pagerenderer.php:1796Same hereclass.t3lib_pagerenderer.php:1990Double space hereclass.t3lib_pagerenderer.php:2019Double space hereclass.t3lib_pagerenderer.php:2040Double space here -
Helmut Hummel commented on patch set 2 06/23/12, 16:25
Thanks Wouter! -
Helmut Hummel commented on patch set 2 06/23/12, 16:25
(1 inline comment) -
Markus Klein commented on patch set 3 06/23/12, 16:25
(2 inline comments) -
Oliver Klee commented on patch set 3 06/23/12, 16:25
(1 inline comment) -
Oliver Klee commented on patch set 3 06/23/12, 16:25
(2 inline comments) -
Helmut Hummel commented on patch set 3 06/23/12, 16:25
(1 inline comment) -
Helmut Hummel uploaded patch set 3 06/23/12, 16:25
-
Christian Kuhn commented on patch set 3 06/23/12, 16:25
will review today -
Christian Kuhn commented on patch set 3 06/23/12, 16:25
(6 inline comments) -
Christian Kuhn uploaded patch set 4 06/23/12, 16:25
-
Christian Kuhn commented on patch set 4 06/23/12, 16:25
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 2 06/23/12, 16:25
(1 inline comment) Hi Helmut, a good step in the correct direction. One thing I would like to you to comment there. Please see my inline comment. -
Steffen Ritter commented on patch set 3 06/23/12, 16:25
Verified; Looks good to me, but someone else must approve at least my Default use cases seem to work -
Philipp Gampe voted on patch set 3 V 0 06/23/12, 16:25
-
Philipp Gampe commented on patch set 3 06/23/12, 16:25
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 06/23/12, 16:25
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 3 06/23/12, 16:25
Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 3 4 comments 06/23/12, 16:25
No score -
Felix Kopp voted on patch set 3 V 0 06/23/12, 16:25
-
Mr. Jenkins commented on patch set 4 06/23/12, 16:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4564/ : SUCCESS -
Wouter Wolters uploaded patch set 2 06/23/12, 16:25
-
Christian Kuhn commented on patch set 4 V 0 06/23/12, 16:25
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 4 06/23/12, 16:25