Review TYPO3_4-7 Abandoned

12269[BUGFIX] error 'class "t3lib_lock" does not exist' in workspace module

Simon Apold CR 0 V 0 Easy +5 −0 updated 06/03/13, 20:49

Commit message

Error occurs for the following settings:
$TYPO3_CONF_VARS['SYS']['systemLog'] = 'file,...'

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 6

  1. Oliver Klee commented on patch set 1 06/26/12, 18:22

    Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 06/26/12, 18:22

    Is this still reproducible after http://forge.typo3.org/issues/36241 is merged in 4.7? To test please checkout workspaces_4-7 current branch in typo3/sysext/workspaces.
  3. Simon Apold commented on patch set 1 06/26/12, 18:22

    (1 inline comment)
    Only related to 4.7-branch
  4. Simon Apold commented on patch set 1 06/26/12, 18:22

    Your right, with the patch in http://forge.typo3.org/issues/36241 this issue is not reproducible any more. It seems, that any other PHP error message or even notice will cause this behaviour. Should i abandon this change?
  5. Wouter Wolters commented on patch set 1 06/26/12, 18:22

    If it solves the problem, then you can abandon this changes.
  6. Simon Apold commented on patch set 1 06/26/12, 18:22

    Abandoned http://forge.typo3.org/issues/36241 solves this issue.