12297[TASK] Clean up phpDoc comments in typo3/sysext/
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 16
- typo3/sysext/recordlist/mod1/index.php+77 −57
- typo3/sysext/recordlist/ext_tables.php+2 −2
- typo3/sysext/reports/interfaces/interface.tx_reports_report.php+5 −6
- typo3/sysext/reports/interfaces/interface.tx_reports_statusprovider.php+5 −6
- typo3/sysext/reports/mod/index.php+14 −16
- typo3/sysext/reports/reports/status/class.tx_reports_reports_status_configurationstatus.php1+23 −15
- typo3/sysext/reports/reports/status/class.tx_reports_reports_status_securitystatus.php+1 −2
- typo3/sysext/reports/reports/status/class.tx_reports_reports_status_status.php1+32 −17
- typo3/sysext/reports/reports/status/class.tx_reports_reports_status_systemstatus.php2+16 −13
- typo3/sysext/reports/reports/status/class.tx_reports_reports_status_typo3status.php+5 −6
- typo3/sysext/reports/reports/status/class.tx_reports_reports_status_warningmessagepostprocessor.php1+5 −6
- typo3/sysext/reports/reports/class.tx_reports_reports_status.php1+22 −20
- typo3/sysext/reports/tasks/class.tx_reports_tasks_systemstatusupdatetask.php+5 −6
- typo3/sysext/reports/tasks/class.tx_reports_tasks_systemstatusupdatetasknotificationemailfield.php+17 −19
- typo3/sysext/reports/ext_localconf.php+2 −2
- typo3/sysext/reports/ext_tables.php+2 −3
Review log 6
-
Oliver Klee commented on patch set 1 06/22/12, 17:52
I would prefer that you didn't submit thisclass.tx_reports_reports_status.php:35@var for fields do not need the field name, just the type and an (optional) descriptionclass.tx_reports_reports_status_configurationstatus.php:37@var for fields do not need the field name, just the type and an (optional) description.Ditto for the other fields.class.tx_reports_reports_status_status.php:42@var for fields do not need the field name, just the type and an (optional) description.Ditto for the other fields.class.tx_reports_reports_status_systemstatus.php:38for fields, the field name is not needed for the @var.class.tx_reports_reports_status_systemstatus.php:195typo: oposite -> oppositeclass.tx_reports_reports_status_warningmessagepostprocessor.php:40missing parameter name -
Christian Kuhn uploaded patch set 2 06/22/12, 17:52
-
Mr. Jenkins commented on patch set 1 06/22/12, 17:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4553/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/22/12, 17:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4554/ : SUCCESS -
Christian Kuhn commented on patch set 2 V 0 06/22/12, 17:52
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 2 06/22/12, 17:52