Review main Merged

12313[TASK] Remove empty constructor from localRecordList

Andy Grunwald CR +2 V +2 Easy +0 −7 updated 06/03/13, 20:49

Commit message

__construct() in localRecordList just calls parent.

This is not needed, because parent constructors are always
called, even if an extending class does not specify this
explicitly.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 7

  1. Christian Kuhn uploaded patch set 2 06/23/12, 20:02

  2. Christian Kuhn uploaded patch set 3 06/23/12, 20:02

  3. Mr. Jenkins commented on patch set 1 06/23/12, 20:02

  4. Mr. Jenkins commented on patch set 2 06/23/12, 20:02

  5. Mr. Jenkins commented on patch set 3 06/23/12, 20:02

  6. Christian Kuhn commented on patch set 3 V 0 06/23/12, 20:02

    by team member; Looks good to me, approved Just changed the commit message a bit. Merged as technical no-brainer.
  7. Christian Kuhn merged patch set 3 06/23/12, 20:02